CodeQL: git checkout HEAD^2 is no longer necessary #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/django-haystack/pysolr/actions/runs/19463495336 shows a warning annotation: > Analyze 1 issue was detected with this workflow: git checkout HEAD^2 is no longer necessary. Please remove this step as Code Scanning recommends analyzing the merge commit for best results.
Contributor
|
Also, see this workflow: https://github.com/django-haystack/pysolr/blob/master/.github/workflows/pypi-release.yml Do we actually use it in the project to publish releases? |
Collaborator
As of the last few releases, yes. It allowed us to stop managing API keys and reuse the work the PyPA has been doing for trusted package signatures. |
acdha
approved these changes
Nov 18, 2025
Contributor
Author
|
Yes, we do use the pypi-release workflow to release to PyPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/django-haystack/pysolr/actions/runs/19463495336 shows a warning annotation: