Skip to content

Commit a0fb30a

Browse files
chore: comment coveralls actions
1 parent 36f5ce1 commit a0fb30a

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

.github/workflows/lint_test.yml

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,10 @@ jobs:
168168
# This step will publish the coverage reports to coveralls.io and
169169
# print a "job" link in the output of the GitHub Action
170170
- name: Publish coverage report to coveralls.io
171+
# upload coverage even if a test run failed
172+
# this is a test, and may be removed in the future
171173
if: always() && (steps.run_tests.outcome == 'success' || steps.run_tests.outcome == 'failure')
174+
# important that we don't fail the workflow when coveralls is down
172175
continue-on-error: true
173176
env:
174177
COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -177,22 +180,31 @@ jobs:
177180
COVERALLS_SERVICE_NAME: github
178181
run: python -m coveralls
179182

180-
coveralls:
183+
coveralls-finish:
181184
name: Indicate completion to coveralls.io
182185
runs-on: ubuntu-latest
183186
needs: test
187+
# we don't want to fail the workflow when coveralls is down
184188
continue-on-error: true
185189
# we always want to ensure we attempt to send a finish to coveralls
186190
if: always()
187-
container: python:3-slim
188191
steps:
192+
# Set up a consistent version of Python
193+
- name: Set up Python 3.9
194+
id: python
195+
uses: actions/setup-python@v2
196+
with:
197+
python-version: '3.9'
189198
- name: Coveralls Finished
190199
continue-on-error: true
191200
env:
192201
COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
193202
COVERALLS_SERVICE_NAME: github
203+
# NOTE: this has a small thing where this will not always be the same with the poetry.lock file
204+
# given how this is installed for one api request, its not worth pinning to me.
205+
# any bugs caused by this can be solved when they occur
194206
run: |
195-
python3 -m pip install --upgrade coveralls -qqq
207+
python3 -m pip install --upgrade coveralls
196208
python3 -m coveralls --finish
197209
198210
artifact:

0 commit comments

Comments
 (0)