Skip to content

Commit 36f5ce1

Browse files
fix: publish coverage on a failed test run and make coveralls optional
1 parent 672fcd0 commit 36f5ce1

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

.github/workflows/lint_test.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,8 @@ jobs:
168168
# This step will publish the coverage reports to coveralls.io and
169169
# print a "job" link in the output of the GitHub Action
170170
- name: Publish coverage report to coveralls.io
171+
if: always() && (steps.run_tests.outcome == 'success' || steps.run_tests.outcome == 'failure')
172+
continue-on-error: true
171173
env:
172174
COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
173175
COVERALLS_FLAG_NAME: coverage-${{ runner.os }}-python-${{ env.PYTHON_VERSION }}
@@ -177,16 +179,20 @@ jobs:
177179

178180
coveralls:
179181
name: Indicate completion to coveralls.io
180-
needs: test
181182
runs-on: ubuntu-latest
183+
needs: test
184+
continue-on-error: true
185+
# we always want to ensure we attempt to send a finish to coveralls
186+
if: always()
182187
container: python:3-slim
183188
steps:
184189
- name: Coveralls Finished
190+
continue-on-error: true
185191
env:
186192
COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
187193
COVERALLS_SERVICE_NAME: github
188194
run: |
189-
python3 -m pip install --upgrade coveralls
195+
python3 -m pip install --upgrade coveralls -qqq
190196
python3 -m coveralls --finish
191197
192198
artifact:

0 commit comments

Comments
 (0)