Skip to content

Conversation

@diegozea
Copy link
Owner

@diegozea diegozea commented Dec 3, 2025

Summary

  • add fragment-based GDT (TS/HA) and TM-score calculations built on MIToS PDB superimposition utilities
  • expose the new structure similarity functions through the PDB API and test them on representative alignments

Testing

  • julia --project -e 'push!(LOAD_PATH,"test"); using MIToSTests; MIToSTests.retest("PDB"); MIToSTests.retest("Structure similarity (GDT/TM-score)")'

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

return mean(values(scores))
end

tm_d0(L::Integer) = max(0.5, 1.24 * (L - 15)^(1 / 3) - 1.8)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid DomainError in tm_score for short targets

tm_d0 currently computes 1.24 * (L - 15)^(1 / 3) - 1.8; when Ltarget is below 15 (short peptides), raising a negative base to the fractional exponent throws a DomainError before the max(0.5, …) guard can run. That means tm_score crashes instead of returning a score for small structures. Handle the Ltarget < 15 case explicitly (e.g., real cube root or early clamp) so short targets are supported.

Useful? React with 👍 / 👎.

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 96.55172% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.96%. Comparing base (4a26a3d) to head (51d5577).

Files with missing lines Patch % Lines
src/PDB/Kabsch.jl 96.55% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   96.97%   96.96%   -0.01%     
==========================================
  Files          64       64              
  Lines        4861     4948      +87     
==========================================
+ Hits         4714     4798      +84     
- Misses        147      150       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

Coverage Status

coverage: 97.145% (-0.01%) from 97.156%
when pulling 51d5577 on codex/implement-gdt-and-tm-score-functions
into 4a26a3d on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants