Skip to content

fix(fixtures): add clean up teardown code to pytest fixture async_sqla_connection #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(fixtures): add clean up teardown code to pytest fixture async_sqla_connection #266

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0994b2f
async_sqla_connection
conste11ations Feb 6, 2025
a2c6b42
fix
conste11ations Feb 6, 2025
a96818f
Merge branch 'master' into fix/DIA-78136
conste11ations Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion fastapi_sqla/_pytest_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,9 @@ def async_sqlalchemy_url(db_url):

@fixture
def async_engine(async_sqlalchemy_url):
return create_async_engine(async_sqlalchemy_url)
engine = create_async_engine(async_sqlalchemy_url)
yield engine
engine.dispose()
Copy link

@thibremy-dialogue thibremy-dialogue Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On your notion page your context is anasync fixture`.

The engine.dispose() will just block on this sync fixture context or behind the scene a future/promise is run and will be completed at some point in time ?

Copy link
Contributor

@hadrien hadrien Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the fixture to an async one and await the dispose call:

    @fixture
    async def async_engine(async_sqlalchemy_url):
        engine = create_async_engine(async_sqlalchemy_url)
        yield engine
        await engine.dispose()

Copy link
Contributor

@arththebird arththebird Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be awaited? IIUC it's an async function

Copy link
Contributor

@hadrien hadrien Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, it is. https://docs.sqlalchemy.org/en/20/orm/extensions/asyncio.html#sqlalchemy.ext.asyncio.AsyncEngine.dispose


@fixture
async def async_sqla_connection(async_engine):
Expand Down