Skip to content

Conversation

@AbhishekA1509
Copy link
Member

Description

This pull request introduces a new API timeout configuration feature and improves the force delete confirmation modal by adding a loading state to the delete button. The most important changes are grouped below by theme.

API Timeout Configuration:

  • Added a setGlobalAPITimeout method to the CoreAPI class, allowing global adjustment of the API request timeout.
  • Exported setGlobalAPITimeout from the API module for use throughout the application.

Force Delete Confirmation Modal Improvements:

  • Updated ForceDeleteConfirmationProps to include an optional isDeleting property, enabling loading state management for the modal.
  • Passed the isDeleting prop to the modal component and the primary button, displaying a loading indicator during deletion. [1] [2]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@AbhishekA1509 AbhishekA1509 self-assigned this Sep 18, 2025
@AbhishekA1509 AbhishekA1509 changed the base branch from develop to main September 18, 2025 11:51
vivek-devtron
vivek-devtron previously approved these changes Sep 19, 2025
@AbhishekA1509 AbhishekA1509 merged commit e2ce781 into main Sep 19, 2025
6 checks passed
@AbhishekA1509 AbhishekA1509 deleted the fix/helm-app-delete branch September 19, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants