Skip to content

Conversation

@Elessar1802
Copy link
Contributor

Description

The first a shortcut timesout it works but consecutive timeouts don't happen unless we trigger a keyup.

Just moved the code that registers the timeout to the end of the handle key down event handler.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@Elessar1802 Elessar1802 marked this pull request as ready for review October 16, 2024 08:15
@Elessar1802 Elessar1802 merged commit 30584c7 into feat/use-register-shortcut Oct 16, 2024
3 checks passed
@Elessar1802 Elessar1802 deleted the fix/use-register-shortcut branch October 16, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants