feat: Deployment History Config Diff & Scope Variables Support in Comparison View across Config Diff #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt in NavLink to check for search params for active state
…er between selectors in header
RohitRaj011
requested review from
vikramdevtron and
vivek-devtron
as code owners
RohitRaj011
changed the title
RohitRaj011
changed the title
…ib into feat/pipeline-deploy-config-diff-revamp
… DeploymentConfigDiff
…f-view feat: TriggerOutput - DeploymentHistoryConfigDiff - revamp UI - using DeploymentConfigDiff
…ib into feat/pipeline-deploy-config-diff-revamp
…storyConfigDiff - renderRunSource integration
eshankvaish
suggested changes
Sep 26, 2024
src/Shared/Components/DeploymentConfigDiff/DeploymentConfigDiff.utils.tsx
Outdated
Show resolved
Hide resolved
src/Shared/Components/DeploymentConfigDiff/DeploymentConfigDiff.utils.tsx
Outdated
Show resolved
Hide resolved
src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/utils.ts
Outdated
Show resolved
Hide resolved
src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/DeploymentHistoryConfigDiff.tsx
Outdated
Show resolved
Hide resolved
...ed/Components/CICDHistory/DeploymentHistoryConfigDiff/DeploymentHistoryConfigDiffCompare.tsx
Outdated
Show resolved
Hide resolved
…s, deployed time incorrect in case of in-progress deployment
…ib into feat/pipeline-deploy-config-diff-revamp
…ib into feat/pipeline-deploy-config-diff-revamp
eshankvaish
previously approved these changes
Oct 3, 2024
vivek-devtron
previously approved these changes
Oct 4, 2024
RohitRaj011
dismissed stale reviews from vivek-devtron and eshankvaish
via
25ead2f
RohitRaj011
changed the title
RohitRaj011
force-pushed
the
feat/pipeline-deploy-config-diff-revamp
branch
from
0e18800 to
0c15444
Compare
…ib into feat/pipeline-deploy-config-diff-revamp
…template data as per API changes
…ing for scrolling selected config into view
…ion present in deployments; fix: Collapse - add resizeObserver to correctly calculate dynamic height; feat: DeploymentConfigDiff - add hideDiffState prop to hide the configuration diff status
…t deployment not available & required changes to DeploymentConfigDiff
eshankvaish
previously approved these changes
Oct 15, 2024
…-diff-revamp-uat feat: Pipeline deploy & Deployment History config diff revamp API & UAT Changes
…ib into feat/pipeline-deploy-config-diff-revamp
vivek-devtron
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scope Variables Support in Config Diff
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist