-
Notifications
You must be signed in to change notification settings - Fork 245
api: Extend side API to all derivative operator shortcuts #2811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2811 +/- ##
==========================================
+ Coverage 82.98% 83.01% +0.03%
==========================================
Files 248 248
Lines 51012 51074 +62
Branches 4491 4491
==========================================
+ Hits 42332 42401 +69
+ Misses 7909 7902 -7
Partials 771 771
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mloubout
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpick comments, might wanna add shortcuts/aliases gradc/divc/... as well
|
|
||
| @property | ||
| def laplace(self): | ||
| def laplace(self, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No laplace is a propery and doesn't take kwargs, laplacian is the one with the kwargs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot, complete oversight on my part
| Custom weights for the finite differences. | ||
| Custom weights for the finite difference coefficients. | ||
| """ | ||
| side = kwargs.get("side") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explicitly add to def
| weights/w: list, tuple, or dict, optional, default=None | ||
| Custom weights for the finite difference coefficients. | ||
| """ | ||
| side = kwargs.get("side") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add to def
FabioLuporini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Addresses #2808