Skip to content

Conversation

@EdCaunt
Copy link
Contributor

@EdCaunt EdCaunt commented Dec 19, 2025

Addresses #2808

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.01%. Comparing base (f020eb1) to head (575d306).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2811      +/-   ##
==========================================
+ Coverage   82.98%   83.01%   +0.03%     
==========================================
  Files         248      248              
  Lines       51012    51074      +62     
  Branches     4491     4491              
==========================================
+ Hits        42332    42401      +69     
+ Misses       7909     7902       -7     
  Partials      771      771              
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.44% <83.33%> (ø)
pytest-gpu-nvc-nvidiaX 68.98% <83.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@mloubout mloubout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpick comments, might wanna add shortcuts/aliases gradc/divc/... as well


@property
def laplace(self):
def laplace(self, **kwargs):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No laplace is a propery and doesn't take kwargs, laplacian is the one with the kwargs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, complete oversight on my part

Custom weights for the finite differences.
Custom weights for the finite difference coefficients.
"""
side = kwargs.get("side")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicitly add to def

weights/w: list, tuple, or dict, optional, default=None
Custom weights for the finite difference coefficients.
"""
side = kwargs.get("side")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add to def

Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants