-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: payloadcms (original, original-wordmark, plain, plain-wordmark) #2548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Hey, just chiming in as & don't have time for a full review, but can we rename the icon itself to payloadcms? I feel like we should pick more specific names when we can, especially in cases like this where there are alternative softwares with similar names |
|
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
|
@Snailedlt @canaleal @lunatic-fox @ReenigneArcher @ConX @weh Could I get a review please? |
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
|
Hey @canaleal, Can You Review these changes? |
devicon.json
Outdated
| "svg": [ | ||
| "original", | ||
| "original-wordmark", | ||
| "plain", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove plain and plain-wordmark as there are no svg files.
| "plain-wordmark" | ||
| ], | ||
| "font": [ | ||
| "original", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Original cant be a font because its not optimized to meet plain icon standards.
The same with original-wordmark.
https://github.com/devicons/devicon/wiki/SVG-Versions
Please create the plain and plain-wordmark svgs.
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Removed 'plain' and 'plain-wordmark' from SVG versions.
|
Hey @canaleal, I Optimized the Original SVG. Review it once if these aren't fine I will create new plain SVG |














Double check these details before you open a PR
developbranch.devicon.jsonfile at the correct alphabetic position as seen hereThis PR closes #2544
Link to prove your SVG is correct and up-to-date.