-
Notifications
You must be signed in to change notification settings - Fork 457
Add Apple Watch SE 3rd generation (Watch7,13-16) #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@copilot I meant Apple Watch SE (3rd gen) |
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
Yes, that's what I implemented - Apple Watch SE (3rd generation) with the Watch7,13-16 identifiers. The devices are defined in the gyb template as |
|
@copilot SE 3rd gen uses S10 chip. |
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
|
@copilot remove sourceLocation lines from the generated Swift file |
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
Apple Watch SE 3rd Generation Support - Implementation Complete
Task Checklist:
Implementation Summary
Added two new Apple Watch device entries:
Device Specifications:
Files Modified:
Source/Device.swift.gyb(chip updated to S10)Source/Device.generated.swift(regenerated with S10, sourceLocation markers removed)Tests/Tests.swift(8 lines added)Code Generation:
python3 Utils/gyb.py --line-directive '' Source/Device.swift.gybCode Generation Validated:
✅ Enum case declarations generated correctly
✅ Identifier mapping (Watch7,13-16) verified
✅ Device descriptions (regular and safe) correct
✅ All device properties properly mapped (diagonal, PPI, screen ratio)
✅ CPU correctly set to S10
✅ Devices included in allWatches array
✅ Test cases added and verified
✅ SourceLocation debug markers removed
CI Pipeline:
The GitHub Actions CI pipeline will validate the changes on macOS with:
Ready for code review and CI validation!
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.