Skip to content

WIP: automatic OS selection for Safari versions #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
developit wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

WIP: automatic OS selection for Safari versions #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
919dac4
attempt
developit Sep 3, 2019
df81f57
Merge branch 'master' into developit-patch-1
developit Jun 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/configure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export default function configure(options) {
}
const parts = browser.toLowerCase().split('-');
const name = parts.join('_');
launchers[name] = {
const launcher = launchers[name] = {
base: 'SauceLabs',
browserName: parts[1]
.replace(/^(msie|ie|internet ?explorer)$/i, 'Internet Explorer')
Expand All @@ -79,6 +79,25 @@ export default function configure(options) {
.replace(/^(macos|mac ?os ?x|os ?x)[ -]+/gi, 'OS X ')
: undefined,
};

if (launcher.browserName === 'safari') {
if (!launcher.platform) {
launcher.platform = 'macOS';
}
if (parseFloat(launcher.version)<11) {
launcher.platform += parts[4] || ' 10.11';
}
}
else if (parts[4]) {
launcher.platform += ' ' + parts[4];
}
const m = launcher.platform && launcher.platform.match(/macOS (\d+(?:\.\d+)?)/);
if (m && parseFloat(m[1])<10.12) {
launcher.platform = launcher.platform.replace(/^macOS /, 'OS X ');
}
const version = parseFloat(launcher.version);
if (version === version|0) launcher.version += '.0';

return name;
}
return browser;
Expand Down