Parse options as YAML string #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I checked in the vendor files, should fix the workflow |
antonmedv
reviewed
Jul 2, 2024
| let optionsArg = core.getInput('options') | ||
| if (optionsArg !== '') { | ||
| for (let [key, value] in Object.entries(JSON.parse(optionsArg))) { | ||
| for (let [key, value] in Object.entries(yaml.load(optionsArg))) { |
Member
There was a problem hiding this comment.
Will it break BC? As somebody can use JSON already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to #85 and also fixes #77 & #72.
I don't think this is a BC break - it was never documented as being in JSON format and also the options were never passed to the command correctly?