Skip to content

feat: Introduce Deduplicator trait to unify mutable and immutable deduplication #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OussamaSaoudi wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: Introduce Deduplicator trait to unify mutable and immutable deduplication #1537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
69a8312
commit reader
OussamaSaoudi Nov 18, 2025
41eba15
manifest
OussamaSaoudi Nov 18, 2025
748141b
rename sequential phase
OussamaSaoudi Nov 19, 2025
6227645
address comments
OussamaSaoudi Dec 10, 2025
4257d32
serde for expression/predicate
OussamaSaoudi Dec 4, 2025
2e700ab
serde tests
OussamaSaoudi Dec 10, 2025
c016ad8
serde
OussamaSaoudi Nov 25, 2025
61f0908
deduplicator
OussamaSaoudi Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions kernel/src/action_reconciliation/log_replay.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
//! actions selected
//!
use crate::engine_data::{FilteredEngineData, GetData, RowVisitor, TypedGetData as _};
use crate::log_replay::deduplicator::Deduplicator;
Copy link
Collaborator Author

@OussamaSaoudi OussamaSaoudi Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imported to have access to the trait's check_record_and_seen

use crate::log_replay::{
ActionsBatch, FileActionDeduplicator, FileActionKey, HasSelectionVector, LogReplayProcessor,
};
Expand Down
3 changes: 2 additions & 1 deletion kernel/src/expressions/column_names.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use std::iter::Peekable;
use std::ops::Deref;

/// A (possibly nested) column name.
#[derive(Debug, Clone, Default, PartialEq, PartialOrd, Eq, Ord)]
#[derive(Debug, Clone, Default, PartialEq, PartialOrd, Eq, Ord, Serialize, Deserialize)]
pub struct ColumnName {
path: Vec<String>,
}
Expand Down Expand Up @@ -449,6 +449,7 @@ macro_rules! __joined_column_expr {
}
#[doc(inline)]
pub use __joined_column_expr as joined_column_expr;
use serde::{Deserialize, Serialize};

#[cfg(test)]
mod test {
Expand Down
Loading
Loading