Skip to content

Conversation

@DrakeLin
Copy link
Collaborator

@DrakeLin DrakeLin commented Dec 2, 2025

What changes are proposed in this pull request?

Remove AppleDouble files (._*, .__*) and macOS extended attributes from test data tarballs.

The macOS metadata was handled in two ways:

  1. AppleDouble files (., .__) - Explicitly deleted:
    find "$name" -name '.
    ' -delete
    find "$name" -name '.__
    ' -delete

  2. Extended attributes (LIBARCHIVE.xattr.*) - Automatically stripped:
    When extracting on Linux, the macOS extended attributes (stored in PAX headers) are ignored:
    tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.provenance'
    tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.quarantine'

This is what Claude code came up with:

  1. Identified affected files
  for f in *.tar.zst; do
    tar --zstd -tvf "$f" 2>&1 | grep -E '/\._|LIBARCHIVE\.xattr'
  done
  Found 25 tarballs containing macOS AppleDouble files (._*, .__*) and extended attributes.

  2. Cleaned each tarball
  for tarball in *.tar.zst; do
    name="${tarball%.tar.zst}"

    # Extract
    tar --zstd -xf "$tarball"

    # Remove AppleDouble files
    find "$name" -name '._*' -delete
    find "$name" -name '.__*' -delete

    # Recompress
    tar --zstd -cf "$tarball" "$name"

    # Cleanup
    rm -rf "$name"
  done

How was this change tested?

Tests pass and opening up a tarball now contains no artifacts

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.72%. Comparing base (c011911) to head (2b453ed).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1534   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files         126      126           
  Lines       34222    34222           
  Branches    34222    34222           
=======================================
  Hits        28996    28996           
  Misses       3816     3816           
  Partials     1410     1410           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

Copy link
Collaborator

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup!

@DrakeLin DrakeLin merged commit 3fc5dc7 into delta-io:main Dec 3, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants