feat: Experimental uc-client – add feature flag to use rustls-tls (and preserve the similar default as for kernel) #1530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotocoding-DB
force-pushed
the
feat/rustls-reqwest
branch
from
2410564 to
7574475
Compare
github-actions
bot
added
the
breaking-change
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1530 +/- ##
=======================================
Coverage 84.75% 84.75%
=======================================
Files 122 122
Lines 33012 33012
Branches 33012 33012
=======================================
Hits 27980 27980
Misses 3660 3660
Partials 1372 1372 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gotocoding-DB
changed the title
Contributor
Author
|
@zachschuermann Hey Zach, please take a look at this small PR to uc-client once you have time. Thanks! |
gotocoding-DB
changed the title
Collaborator
zachschuermann
left a comment
zachschuermann
left a comment
There was a problem hiding this comment.
actually i think we could just always do rustls - opened something in #1533
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
The set of flags are exactly the same as for default engine in kernel: https://github.com/delta-io/delta-kernel-rs/blob/main/kernel/Cargo.toml#L137-L144:
How was this change tested?