refactor: migrate custom feature functions to generic is_feature_enabled/is_feature_supported #1519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1519 +/- ##
==========================================
+ Coverage 84.72% 84.76% +0.03%
==========================================
Files 126 126
Lines 35797 35677 -120
Branches 35797 35677 -120
==========================================
- Hits 30330 30242 -88
+ Misses 4006 3975 -31
+ Partials 1461 1460 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
the
breaking-change
DrakeLin
force-pushed
the
drake-lin_data/refactor-x-enabled-and-supported
branch
3 times, most recently
from
262bf8c to
ab09aea
Compare
nicklan
reviewed
Dec 3, 2025
Member
nicklan
left a comment
nicklan
left a comment
There was a problem hiding this comment.
mostly looks great, love the number of removed vs added lines :)
I just wonder, should we be adding back in the removed tests with valid p and ms?
Collaborator
Author
Which tests are you referring to? I might've lost track. |
OussamaSaoudi
approved these changes
Dec 5, 2025
DrakeLin
force-pushed
the
drake-lin_data/refactor-x-enabled-and-supported
branch
from
42cac70 to
961326b
Compare
github-actions
bot
added
the
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Refactored custom
is_x_supported()andis_x_enabled()functions intable_configuration.rsto use the genericis_feature_enabled(&TableFeature)andis_feature_supported(&TableFeature)functionsHow was this change tested?
Several test tables had invalid protocols where delta.enableChangeDataFeed=true was set but the protocol (3,7 with table features) didn't include changeDataFeed in writerFeatures. This is invalid because table features protocol requires explicit feature listing. Fixed: