Update submodule link to reflect https style #981
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @raviguptaamd , can you fix the dco error? |
Signed-off-by: raviguptaamd <ravi.gupta@amd.com>
Contributor
Author
|
@hwchen2017 - DCO fixed. Thanks |
hwchen2017
approved these changes
Jul 4, 2025
jouw
pushed a commit
to jouw/DeepSpeedExamples
that referenced
this pull request
Jul 6, 2025
Signed-off-by: raviguptaamd <ravi.gupta@amd.com> Signed-off-by: jouw <jouw@foxmail.com>
hwchen2017
added a commit
that referenced
this pull request
Jul 8, 2025
* Add file extension (#980) Signed-off-by: Hongwei Chen <hongweichen@microsoft.com> Signed-off-by: jouw <jouw@foxmail.com> * fix init weights issue for critic/reward model Signed-off-by: jouw <jouw@foxmail.com> * Update submodule link to reflect https style (#981) Signed-off-by: raviguptaamd <ravi.gupta@amd.com> Signed-off-by: jouw <jouw@foxmail.com> * fix formatting issue Signed-off-by: jouw <jouw@foxmail.com> --------- Signed-off-by: Hongwei Chen <hongweichen@microsoft.com> Signed-off-by: jouw <jouw@foxmail.com> Signed-off-by: raviguptaamd <ravi.gupta@amd.com> Co-authored-by: Hongwei Chen <33092912+hwchen2017@users.noreply.github.com> Co-authored-by: raviguptaamd <ravi.gupta@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git style links may often not work, especially in CI servers as it requires 'ssh' key setup even for READ operations.
Please accept the change to reflect https style links.