Skip to content

Conversation

@Amnah199
Copy link
Contributor

@Amnah199 Amnah199 commented Dec 6, 2024

Related to issue #356

Updated tutorials 27, 28, 29 in this PR.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Amnah199 Amnah199 marked this pull request as draft December 6, 2024 10:12
@Amnah199 Amnah199 changed the title Replace Generators with ChatGenerators Replace Generators with ChatGenerators (1/3) Dec 8, 2024
@Amnah199 Amnah199 marked this pull request as ready for review December 8, 2024 22:20
@bilgeyucel bilgeyucel self-requested a review December 12, 2024 08:50
Copy link
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments to make these changes future-proof. Other than those, LGTM ✅

@Amnah199 Amnah199 merged commit 58f8c5d into main Dec 13, 2024
8 checks passed
@Amnah199 Amnah199 deleted the replace-generator-with-chatgen branch December 13, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants