Fix: ensure all functions have been called before running chat generator #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
anakin87
reviewed
Nov 26, 2024
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
In general, the change makes sense to me.
I would like @bilgeyucel to take a look at it as well.
Also, I see that the tests are failing but IDK why.
Contributor
It seems like a connection issue on OpenAI side. |
Contributor
Author
|
Since I've opened the PR from a fork, secrets are not read. Will reopen soon from a branch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix to make sure all functions have been called before running
chat_generator.runagain.