pd: update paddlepaddle version to release/3.0 #4694
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the PaddlePaddle dependency from release candidates (3.0.0rc*) to the official 3.0.0 release and adjusts corresponding documentation and workflows accordingly.
- Updated installation instructions and URLs for PaddlePaddle in source install and easy-install documentation.
- Modified dependency requirements in the backend and CI workflow files to target PaddlePaddle 3.0.0.
- Updated the CUDA version references in documentation and workflows.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| doc/install/install-from-source.md | Updated PaddlePaddle version and download URL; however, the comment indicating CUDA version remains as "# cu123" while the command now targets cu126. |
| doc/install/easy-install.md | Updated installation command and tab item labels to match the new CUDA version and PaddlePaddle release. |
| backend/find_paddle.py | Updated paddle version requirement from a beta-release to the stable release. |
| .github/workflows/test_python.yml | Updated pip installation command for PaddlePaddle from a release candidate to the stable release. |
| .github/workflows/test_cuda.yml | Updated pip installation for GPU testing to reflect the stable release and correct CUDA version. |
Comments suppressed due to low confidence (1)
doc/install/install-from-source.md:101
- The comment indicates CUDA 123, but the installation command below now uses a URL for cu126. Please update the comment to reflect the correct CUDA version to avoid confusion.
# cu123
📝 WalkthroughWalkthroughThe pull request updates the installation commands for the PaddlePaddle library across GitHub Actions workflows, a backend script, and documentation. The changes replace pre-release versions with the stable 3.0.0 release and adjust associated URLs, including modifications to CUDA version references. Additionally, the dependency version requirement in the backend script is updated to enforce the stable release. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (29)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/test_python.yml (1)
34-34: Consider removing the--preflag for stable release.The version has been correctly updated from
3.0.0rc1to the stable3.0.0release. However, the--preflag is typically used for pre-release versions and may not be necessary for a stable release.- source/install/uv_with_retry.sh pip install --system --pre "paddlepaddle==3.0.0" -i https://www.paddlepaddle.org.cn/packages/stable/cpu/ + source/install/uv_with_retry.sh pip install --system "paddlepaddle==3.0.0" -i https://www.paddlepaddle.org.cn/packages/stable/cpu/doc/install/install-from-source.md (1)
101-102: Updated installation command to stable release with CUDA 12.6.The installation command has been updated from the release candidate to the stable 3.0.0 version of PaddlePaddle with CUDA 12.6 support. The comment on line 101 still says "cu123" which should be updated to match the new CUDA version.
- # cu123 + # cu126
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/test_cuda.yml(1 hunks).github/workflows/test_python.yml(1 hunks)backend/find_paddle.py(1 hunks)doc/install/easy-install.md(3 hunks)doc/install/install-from-source.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (26)
- GitHub Check: Test Python (6, 3.12)
- GitHub Check: Test Python (6, 3.9)
- GitHub Check: Test Python (5, 3.12)
- GitHub Check: Test Python (5, 3.9)
- GitHub Check: Test Python (4, 3.12)
- GitHub Check: Build wheels for cp310-manylinux_aarch64
- GitHub Check: Test Python (4, 3.9)
- GitHub Check: Build wheels for cp311-win_amd64
- GitHub Check: Test Python (3, 3.12)
- GitHub Check: Build wheels for cp311-macosx_arm64
- GitHub Check: Test Python (3, 3.9)
- GitHub Check: Build wheels for cp311-macosx_x86_64
- GitHub Check: Test Python (2, 3.12)
- GitHub Check: Build C++ (rocm, rocm)
- GitHub Check: Build wheels for cp311-manylinux_x86_64
- GitHub Check: Test Python (2, 3.9)
- GitHub Check: Build C++ (cuda120, cuda)
- GitHub Check: Build C library (2.14, >=2.5.0rc0,<2.15, libdeepmd_c_cu11.tar.gz)
- GitHub Check: Build wheels for cp311-manylinux_x86_64
- GitHub Check: Test Python (1, 3.12)
- GitHub Check: Test C++ (false)
- GitHub Check: Build C++ (cuda, cuda)
- GitHub Check: Build C library (2.18, libdeepmd_c.tar.gz)
- GitHub Check: Analyze (c-cpp)
- GitHub Check: Test Python (1, 3.9)
- GitHub Check: Test C++ (true)
🔇 Additional comments (7)
backend/find_paddle.py (1)
108-108: Version requirement updated to stable release.The version requirement for the PaddlePaddle package has been correctly updated from a beta version to the stable 3.0.0 release, which aligns with the PR objectives.
.github/workflows/test_cuda.yml (1)
54-54: Updated to stable PaddlePaddle version with appropriate CUDA support.The installation command has been updated to use the stable PaddlePaddle 3.0.0 release with CUDA 12.6 support. This aligns with the PR objectives and ensures compatibility with the container image specified in line 22 (
nvidia/cuda:12.6.2-cudnn-devel-ubuntu22.04).doc/install/install-from-source.md (2)
104-104: Updated CUDA 11.8 installation command to stable release.The installation command for CUDA 11.8 has been correctly updated from the release candidate to the stable 3.0.0 version of PaddlePaddle.
106-106: Updated CPU installation command to stable release.The installation command for the CPU version has been correctly updated from the release candidate to the stable 3.0.0 version of PaddlePaddle.
doc/install/easy-install.md (3)
193-198: Updated PaddlePaddle GPU Installation Command for CUDA 12.6The command now installs the stable release (
3.0.0) from the updated URL (https://www.paddlepaddle.org.cn/packages/stable/cu126/), replacing the previous release candidate version. This aligns with the PR objective to update the PaddlePaddle version.Note: Ensure that any related auto-download URL for
paddle_inference_dir(mentioned in the PR notes) is also updated consistently.
202-207: Updated PaddlePaddle GPU Installation Command for CUDA 11.8The installation command for CUDA 11.8 has been updated to the stable version (
3.0.0) while retaining the same package index URL (https://www.paddlepaddle.org.cn/packages/stable/cu118/). This change is consistent with the updates for the GPU commands and reflects the intended stable release.Suggestion: Double-check that all system and CUDA-specific instructions elsewhere refer to the correct version if applicable.
211-216: Updated PaddlePaddle CPU Installation CommandThe CPU installation command now installs
paddlepaddle==3.0.0from the stable URL (https://www.paddlepaddle.org.cn/packages/stable/cpu/), in line with the transition from a pre-release version. This update aligns with the overall documentation changes for the stable PaddlePaddle release.Additional Check: Verify that all related documentation sections and documentation links reflect this stable version update.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #4694 +/- ##
==========================================
+ Coverage 84.80% 84.82% +0.02%
==========================================
Files 692 692
Lines 66396 66512 +116
Branches 3539 3538 -1
==========================================
+ Hits 56306 56420 +114
- Misses 8949 8952 +3
+ Partials 1141 1140 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HydrogenSulfate
force-pushed
the
update_pd_to_r3
branch
from
84d0271 to
78627bb
Compare
HydrogenSulfate
force-pushed
the
update_pd_to_r3
branch
from
78627bb to
37d5d4d
Compare
HydrogenSulfate
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/CMakeLists.txt (3)
40-41: Clarify Paddle Release Commit Details
The added comments clearly indicate that the commit ID "6ed5dd3" is associated with Paddle release/3.0 and provide a direct link to the release. This enhances traceability for future maintainers.
45-46: Updated CUDA 11 Inference Library Message
The message now specifies that the CUDA 11 environment will download the "CUDA11.8 inference lib". Please verify that the version "11.8" is consistently referenced across all related documentation and workflows.
52-56: Updated CUDA 12 Inference Library Details
The message and URL for the CUDA 12 case have been updated—now mentioning "CUDA12.6 inference lib" and pointing to the new URL with the commit ID. Please ensure that these changes match the stable release requirements and are reflected in related documentation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
doc/install/install-from-source.md(1 hunks)source/CMakeLists.txt(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- doc/install/install-from-source.md
⏰ Context from checks skipped due to timeout of 90000ms (25)
- GitHub Check: Build wheels for cp310-manylinux_aarch64
- GitHub Check: Test Python (6, 3.12)
- GitHub Check: Build wheels for cp311-win_amd64
- GitHub Check: Test Python (6, 3.9)
- GitHub Check: Test Python (5, 3.12)
- GitHub Check: Test Python (5, 3.9)
- GitHub Check: Build wheels for cp311-manylinux_x86_64
- GitHub Check: Test Python (4, 3.12)
- GitHub Check: Build wheels for cp311-manylinux_x86_64
- GitHub Check: Analyze (python)
- GitHub Check: Test Python (4, 3.9)
- GitHub Check: Test Python (3, 3.12)
- GitHub Check: Analyze (c-cpp)
- GitHub Check: Test Python (3, 3.9)
- GitHub Check: Test Python (2, 3.12)
- GitHub Check: Test Python (2, 3.9)
- GitHub Check: Build C++ (rocm, rocm)
- GitHub Check: Test Python (1, 3.12)
- GitHub Check: Build C++ (cuda120, cuda)
- GitHub Check: Test C++ (false)
- GitHub Check: Build C++ (cuda, cuda)
- GitHub Check: Test Python (1, 3.9)
- GitHub Check: Test C++ (true)
- GitHub Check: Build C library (2.14, >=2.5.0rc0,<2.15, libdeepmd_c_cu11.tar.gz)
- GitHub Check: Build C library (2.18, libdeepmd_c.tar.gz)
🔇 Additional comments (2)
source/CMakeLists.txt (2)
47-49: Revised Download URL for CUDA 11 Inference Library
The download URL has been updated to include the specific commit ID for the Paddle release/3.0. Confirm that the URL is correct and accessible, as it is critical for automated downloads in the build process.
64-71: Updated CPU Inference Library Message and URL
The message for the CPU version now correctly states that the CPU inference lib will be downloaded, and the URL has been updated with the commit ID information. This change looks good; just ensure consistency with the other Paddle release/3.0 references.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@HydrogenSulfate I reproduce the same behavior in a Google Colab environment. After 10 minutes, uv is still stuck in downloading paddlepaddle-gpu. |
3 participants
Update related document as paddle 3.0 has been released https://github.com/PaddlePaddle/Paddle/releases/tag/v3.0.0
TODO: update
paddle_inference_dirauto download urlSummary by CodeRabbit
Documentation
Chores