Skip to content

Conversation

@Cstandardlib
Copy link
Collaborator

@Cstandardlib Cstandardlib commented Dec 9, 2025

Linked Issue

Fix #6745

What's changed?

  • Exit immediately INPUT kpar is not supported on DSP build.
  • ONLY kpar == NPROC is permitted.
  • Use WARNING_QUIT instead of exit in both KPAR input tests(listed as follows).

Note

  • If NPROC > KPAR, this check will find the problem and quit. (Only applicable to DSP)
  • If NPROC < KPAR, the program will exit by Parallel_Global::divide_mpi_groups in source/source_base/parallel_global.cpp.
void Parallel_Global::divide_mpi_groups(...)
{
...
    if (procs < num_groups)
    {
        std::cout << "Error: Number of processes (" << procs << ") must be greater than the number of groups ("
                  << num_groups << ")." << std::endl;
        exit(1);
    }

Tests

  • Unittests are provided for this case.

@Cstandardlib Cstandardlib marked this pull request as draft December 9, 2025 12:33
@Cstandardlib Cstandardlib marked this pull request as ready for review December 11, 2025 10:23
@mohanchen mohanchen added GPU & DCU & HPC GPU and DCU and HPC related any issues Refactor Refactor ABACUS codes labels Dec 12, 2025
@Cstandardlib Cstandardlib marked this pull request as draft December 12, 2025 04:49
@Cstandardlib Cstandardlib marked this pull request as ready for review December 12, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GPU & DCU & HPC GPU and DCU and HPC related any issues Refactor Refactor ABACUS codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] False Results on DSP

2 participants