feat: SDK7 implement ADR-245 (player components) #5724
Conversation
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 6/7:More |
gonpombo8
left a comment
gonpombo8
left a comment
There was a problem hiding this comment.
what about the perf of this when we have many users on multiple scenes ?
Does it affects in something ? It seems costly but im not sure
| @@ -0,0 +1,6 @@ | |||
| export * from './deleteComponent' | |||
There was a problem hiding this comment.
cant we use @dcl/sdk here so we avoid duplicating all these files ?
And use the ones that are already tested ?
There was a problem hiding this comment.
Absolutely we can, I didn't try to iterate fast, this is not going to be implemented by me, only giving a PoC to show it could work
| export { PBPointerEventsResult } from '../../../../protocol/decentraland/sdk/components/pointer_events_result.gen' | ||
|
|
||
| const MAX_ENTITY_VERSION = 0xffff | ||
| const AVATAR_RESERVED_ENTITY_NUMBER = { from: 10, to: 200 } |
There was a problem hiding this comment.
this is kind of a limitation right ? We can't support more that 190 users 🤔 ?
What when we have the sdk7 avatar scene and foreing entities ? How this two things are going to live together ?
There was a problem hiding this comment.
Actually, the range defined in the ADR is from 32 to 256 (224 players limit). AFAIK, the current limit in the Foundation client is 100 players. I'm not sure how realistic it is to think about more than 224 players but the ADR-245 is in Review state and comments and modifications are welcome.
Regarding the foreign entities, I'm not sure about how they and this are going to live together as I don't know what is the ETA to get the foreign entities a fact. The first (and original) idea was to do this with the Foreign entities (in the Protocol Squad), but due to the complexity and the scope of this, we decided to move with this approach.
Bevy and Godot implementation doesn't have a JavaScript Scene for avatars, and probably Explorer-Alpha goes with that approach, it'd be embedded in the explorer itself.
Each player is only in one Scene, so the Transform is only sent to it. I don't see any perf issue but we'd need to do some tests. |
This is a PoC to demonstrate the implementation of ADR-245 is possible with current state of renderer.
What?
Implements https://adr.decentraland.org/adr/ADR-245
Implemented and tested:
Entityeach playernull/delete component)