Skip to content

fix: asset bundle failing to load #5713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dalkia wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

fix: asset bundle failing to load #5713

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
564e333
Catching exception if asset bundle fails to load
dalkia Sep 15, 2023
ca90b68
Update AssetBundlesLoader.cs
dalkia Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions ...ts/Scripts/MainScripts/DCL/Controllers/AssetManager/AssetBundles/AB/AssetBundlesLoader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,15 @@ private async UniTask LoadAssetBundlesAsync(CancellationToken cancellationToken)
float time = Time.realtimeSinceStartup;

assetBundleInfoToLoad = highPriorityLoadQueue.Dequeue();
await LoadAssetBundleAsync(assetBundleInfoToLoad, cancellationToken);

try
{
await LoadAssetBundleAsync(assetBundleInfoToLoad, cancellationToken);
}
catch (Exception e)
{
assetBundleInfoToLoad.onFail?.Invoke(new Exception("Asset bundle failed to load"));
}

if (IsLoadBudgetTimeReached(time))
{
Expand All @@ -116,7 +124,15 @@ private async UniTask LoadAssetBundlesAsync(CancellationToken cancellationToken)
float time = Time.realtimeSinceStartup;

assetBundleInfoToLoad = lowPriorityLoadQueue.Dequeue();
await LoadAssetBundleAsync(assetBundleInfoToLoad, cancellationToken);

try
{
await LoadAssetBundleAsync(assetBundleInfoToLoad, cancellationToken);
}
catch (Exception e)
{
assetBundleInfoToLoad.onFail?.Invoke(new Exception("Asset bundle failed to load"));
}

if (IsLoadBudgetTimeReached(time))
{
Expand Down