chore: update unity project version to unity2022.3.6f1 #5529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th UberPost shader and with building process error
…into test/perf-profiling-unity2022.3.4f1
…om unity 2022.3.6f1
…o' in project settings asset file
…into test/perf-profiling-unity2022.3.4f1
… black to improve avatars blending with background in passport screen
…into test/perf-profiling-unity2022.3.4f1
…into test/perf-profiling-unity2022.3.4f1
Member
Author
|
Pending:
|
pravusjif
changed the title
… if CI problem comes from cached libraries Signed-off-by: Pravus <pravusjif@gmail.com>
…l to see if CI problem comes from cached libraries" This reverts commit 8e8a23b.
Member
Author
|
the CI error was due to using cached libraries for Unity 2021.3.22 instead of the new version |
github-actions
bot
requested review from
Kinerius,
kwssbocian and
sandrade-dcl
Signed-off-by: Pravus <pravusjif@gmail.com>
Signed-off-by: Pravus <pravusjif@gmail.com>
anicalbano
approved these changes
Aug 24, 2023
Contributor
anicalbano
left a comment
anicalbano
left a comment
There was a problem hiding this comment.
✅ PR reviewed by QA. No issues where found on our checks.
Kinerius
approved these changes
Aug 24, 2023
Contributor
Kinerius
left a comment
Kinerius
left a comment
There was a problem hiding this comment.
Looks Good!
Can you also update this?
https://github.com/decentraland/unity-renderer/blob/test/perf-profiling-unity2022.3.4f1/README.md?plain=1#L24
Signed-off-by: Pravus <pravusjif@gmail.com>
Member
Author
|
I'll update with |
pbosio
approved these changes
Aug 25, 2023
pravusjif
added
the
do not merge
…into test/perf-profiling-unity2022.3.4f1
pravusjif
added a commit
that referenced
this pull request
Aug 30, 2023
This reverts commit e0095ef.
pravusjif
added a commit
that referenced
this pull request
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unity 2021.3.22f1 LTStoUnity 2022.3.6f1 LTS14.0.8. Re-applying our alpha value fixRenderTargetHandleusages (marked asobsoletesince URP 13) with the newRTHandleclass but couldn't get it to work. Since in URP 14.0.8 (the one used with Unity 2022.3) the old "obsolete" class still works, I'm leaving that implementation as it was. I created an informative draft PR to tackle that in the future, since probably that change will be mandatory to update the URP version further.TESTING
This build should be tested as throroughly as a Release Candidate, and also adding:
TEST LINKS