Skip to content

Fix: Cross Origin Authorization Error. #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Fix: Cross Origin Authorization Error. #85

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7c2dc1
add code challenge params
ousid Nov 12, 2024
7675f4f
add code challenge to provider
dcblogdev Nov 14, 2024
136a4df
add more detailed error and updated test
dcblogdev Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions src/MsGraph.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,32 +28,32 @@ class MsGraph
{
public function contacts(): Contacts
{
return new Contacts();
return new Contacts;
Copy link
Contributor Author

@ousid ousid Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styling.

}

public function emails(): Emails
{
return new Emails();
return new Emails;
}

public function files(): Files
{
return new Files();
return new Files;
}

public function sites(): Sites
{
return new Sites();
return new Sites;
}

public function tasklists(): TaskLists
{
return new TaskLists();
return new TaskLists;
}

public function tasks(): Tasks
{
return new Tasks();
return new Tasks;
}

protected static string $baseUrl = 'https://graph.microsoft.com/v1.0/';
Expand Down Expand Up @@ -83,7 +83,7 @@ public static function setUserModel(string $model): static
{
self::$userModel = $model;

return new static();
return new static;
}

/**
Expand Down Expand Up @@ -111,7 +111,15 @@ public function connect(?string $id = null): Redirector|RedirectResponse
}

if (! request()->has('code') && ! $this->isConnected($id)) {
return redirect($provider->getAuthorizationUrl());
$codeVerifier = bin2hex(random_bytes(32));
$codeChallenge = rtrim(
strtr(base64_encode(hash('sha256', $codeVerifier, true)), '+/', '-_'), '='
);

return redirect($provider->getAuthorizationUrl([
'code_challenge' => $codeChallenge,
'code_challenge_method' => 'S256',
]));
}

if (request()->has('code')) {
Expand Down
Loading