-
Notifications
You must be signed in to change notification settings - Fork 42
Fix: Handle max retries in awaitWorkflowResult #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@maxdml Kindly review at your convenience. |
Thanks Varad, yes let's fix the |
maxdml
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #190 (comment)
|
But if we look at the failing tests, not all handles are returning an error. // @maxdml |
This is because the workflow is eventually allowed to complete, using
|
|
I have made the required changes, kindly review // @maxdml |
0b1e946 to
ca44c5d
Compare
vuln check are fixed now (I rebased your branch on top of main) |
…/dbos-transact-golang into feat/handle_max_retries
|
Made the changes // @maxdml |
Fixes #143