Skip to content

Conversation

@vr-varad
Copy link
Contributor

@vr-varad vr-varad commented Nov 18, 2025

Fixes #143

@vr-varad
Copy link
Contributor Author

@maxdml Kindly review at your convenience.
Would you like me to add tests as well?

@maxdml
Copy link
Collaborator

maxdml commented Nov 20, 2025

@maxdml Kindly review at your convenience. Would you like me to add tests as well?

Thanks Varad, yes let's fix the TestWorkflowQueues/QueueWorkflowDLQ test. All the handles calls to GetResult should yield the max retries error now. (Because the mere fact of attempting to recover the workflow moves it to the DLQ and sets the error.)

Copy link
Collaborator

@maxdml maxdml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vr-varad
Copy link
Contributor Author

vr-varad commented Dec 2, 2025

But if we look at the failing tests, not all handles are returning an error. // @maxdml
(https://github.com/dbos-inc/dbos-transact-golang/actions/runs/19861284355/job/56911788635?pr=190#step:11:2082)

@maxdml
Copy link
Collaborator

maxdml commented Dec 2, 2025

But if we look at the failing tests, not all handles are returning an error. // @maxdml (https://github.com/dbos-inc/dbos-transact-golang/actions/runs/19861284355/job/56911788635?pr=190#step:11:2082)

This is because the workflow is eventually allowed to complete, using dlqCompleteEvent.Set(). When the workflow function returns, it overwrites the status to success. This is expected for now. Let's just do:

  1. Test all handles, they should error
  2. unstuck the workflow with dlqCompleteEvent.Set()

@vr-varad
Copy link
Contributor Author

vr-varad commented Dec 2, 2025

I have made the required changes, kindly review // @maxdml
Not aware of why the security checks are failing, is it related to go version?

@vr-varad vr-varad requested a review from maxdml December 2, 2025 22:06
@maxdml maxdml force-pushed the feat/handle_max_retries branch from 0b1e946 to ca44c5d Compare December 3, 2025 19:14
@maxdml
Copy link
Collaborator

maxdml commented Dec 3, 2025

I have made the required changes, kindly review // @maxdml Not aware of why the security checks are failing, is it related to go version?

vuln check are fixed now (I rebased your branch on top of main)

@vr-varad
Copy link
Contributor Author

vr-varad commented Dec 4, 2025

Made the changes // @maxdml

@vr-varad vr-varad requested a review from maxdml December 4, 2025 06:54
@maxdml maxdml merged commit e92c6ef into dbos-inc:main Dec 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle max retries in awaitWorkflowResult

2 participants