Skip to content

chore(docs): added further comments for clarity #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfranzke merged 2 commits into from
Nov 3, 2022
Merged

chore(docs): added further comments for clarity #144

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c15772c
chore(docs): added further comments for clarity
mfranzke Nov 3, 2022
68804e1
Merge branch 'main' into chore-docs-added-comments-for-clarity
mfranzke Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions source/css/_db-ui-core.variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
/* *****
This file summarizes the general variables relevant for using DB UI Core with SCSS.
***** */

// Define the path for both image and font folders
$icons-path: "../../icons/" !default;
$images-path: "../../images/" !default;
Expand Down
4 changes: 4 additions & 0 deletions source/css/_fonts.general.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
/* *****
SCSS placeholder for general font declarations
***** */

@import "db-ui-core.variables";

%general-fonts {
Expand Down
4 changes: 4 additions & 0 deletions source/css/db-ui-core.general.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
/* *****
This is mainly meant to get included within scoped components like e.g. within StencilJS Custom Components / DB UI Elements
***** */

@import "db-ui-core.variables";
@import "@csstools/normalize.css/normalize";
@import "../_patterns/00-base/init";
Expand Down
7 changes: 7 additions & 0 deletions source/css/db-ui-core.vars.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
/* *****
This file is meant to get included globally on a page with a standard set of variables and font references,
if you're using only partials – either Web Components out of DB UI Elements or the partial CSS generated out
of DB UI Core for each element and component.
***** */

// Define the path for both image and font folders
$icons-path: "../icons/" !default;
$images-path: "../images/" !default;
Expand All @@ -12,6 +18,7 @@ $fonts-path: "../fonts/" !default;
@import "../_patterns/00-base/icons/icons.font-faces";

:root {
// Overwriting the referenced SVG icons as this is going to get inlined and the path would be relative to the pages URL instead of the CSS, which would break
--db-ic-search-24: url(#{$icons-path}functional/images/action/db_ic_search_24.svg);
--db-ic-expand-more-20: url(#{$icons-path}functional/images/navigation/db_ic_expand_more_20.svg);
}