Skip to content

Conversation

@tdikland
Copy link
Contributor

@tdikland tdikland commented Oct 14, 2025

Changes

Add new geo check: is_not_null_island.

Linked issues

Resolves #603

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • added end-to-end tests
  • added performance tests

@tdikland tdikland requested a review from a team as a code owner October 14, 2025 08:00
@tdikland tdikland requested review from pratikk-databricks and removed request for a team October 14, 2025 08:00
@mwojtyczka mwojtyczka requested a review from Copilot October 16, 2025 09:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new geospatial row check is_not_null_island to flag geometries at the “Null Island” (POINT(0 0)), with corresponding tests, benchmarks, and documentation updates.

  • Introduces is_not_null_island in geo/check_funcs with rule registration
  • Adds integration and performance tests, and YAML/MDX examples
  • Updates docs to list and demonstrate the new check

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/resources/all_row_geo_checks.yaml Adds is_not_null_island to the all-geo-checks YAML.
tests/perf/test_apply_checks.py Adds a benchmark for is_not_null_island.
tests/integration/test_row_checks_geo.py Adds an integration test verifying behavior and error message for is_not_null_island.
tests/integration/test_apply_checks.py Adds is_not_null_island to the “all geo checks” application test (string and Column inputs).
src/databricks/labs/dqx/geo/check_funcs.py Implements and registers is_not_null_island.
docs/dqx/docs/reference/quality_checks.mdx Documents the new check and adds examples; fixes a table row formatting issue.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mwojtyczka mwojtyczka requested a review from Copilot November 6, 2025 17:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mwojtyczka mwojtyczka requested a review from Copilot November 11, 2025 22:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@ghanse ghanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add is_not_null_island check

3 participants