-
Notifications
You must be signed in to change notification settings - Fork 74
add null island check #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a new geospatial row check is_not_null_island to flag geometries at the “Null Island” (POINT(0 0)), with corresponding tests, benchmarks, and documentation updates.
- Introduces is_not_null_island in geo/check_funcs with rule registration
- Adds integration and performance tests, and YAML/MDX examples
- Updates docs to list and demonstrate the new check
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/resources/all_row_geo_checks.yaml | Adds is_not_null_island to the all-geo-checks YAML. |
| tests/perf/test_apply_checks.py | Adds a benchmark for is_not_null_island. |
| tests/integration/test_row_checks_geo.py | Adds an integration test verifying behavior and error message for is_not_null_island. |
| tests/integration/test_apply_checks.py | Adds is_not_null_island to the “all geo checks” application test (string and Column inputs). |
| src/databricks/labs/dqx/geo/check_funcs.py | Implements and registers is_not_null_island. |
| docs/dqx/docs/reference/quality_checks.mdx | Documents the new check and adds examples; fixes a table row formatting issue. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ghanse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
Add new geo check:
is_not_null_island.Linked issues
Resolves #603
Tests