Skip to content

Conversation

@ronanstokes-db
Copy link
Contributor

Proposed changes

Documentation updates for next release

Types of changes

What types of changes does your code introduce to dbldatagen?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to tutorials, tests or examples
  • Non code change (readme, images or other non-code assets)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • Submission does not reduce code coverage numbers
  • Submission does not increase alerts or messages from LGTM

Further comments

Documentation changes only

@ronanstokes-db ronanstokes-db self-assigned this Feb 5, 2023
@ronanstokes-db ronanstokes-db added the documentation Improvements or additions to documentation label Feb 5, 2023
@ronanstokes-db ronanstokes-db added this to the v0.3.1 milestone Feb 5, 2023
@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Merging #151 (eb35a44) into master (04c8bd0) will not change coverage.
The diff coverage is n/a.

❗ Current head eb35a44 differs from pull request most recent head ea63d71. Consider uploading reports for the commit ea63d71 to get more accurate results

@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   90.15%   90.15%           
=======================================
  Files          22       22           
  Lines        2439     2439           
  Branches      396      396           
=======================================
  Hits         2199     2199           
  Misses        157      157           
  Partials       83       83           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Generating JSON data
--------------------
There are several method for generating JSON data:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Methods plural here

@ronanstokes-db ronanstokes-db merged commit 571fae2 into master Feb 8, 2023
@ronanstokes-db ronanstokes-db deleted the doc_updates_4_0 branch March 25, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants