Skip to content

Conversation

@ronanstokes-db
Copy link
Contributor

@ronanstokes-db ronanstokes-db commented Dec 6, 2022

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers.
If it fixes a bug or resolves a feature request, please provide a link to that issue.

Types of changes

What types of changes does your code introduce to dbldatagen?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to tutorials, tests or examples
  • Non code change (readme, images or other non-code assets)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • Submission does not reduce code coverage numbers
  • Submission does not increase alerts or messages from LGTM

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #143 (d73dc48) into master (981a5a4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files          21       21           
  Lines        2161     2161           
  Branches      367      367           
=======================================
  Hits         1878     1878           
  Misses        183      183           
  Partials      100      100           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ronanstokes-db ronanstokes-db reopened this Dec 6, 2022
@ronanstokes-db ronanstokes-db changed the title updates to build process v2 - PR for debug purposes only updates to build process Dec 6, 2022
@ronanstokes-db ronanstokes-db self-assigned this Dec 6, 2022
@ronanstokes-db ronanstokes-db added bug Something isn't working Build process improvement labels Dec 6, 2022
@ronanstokes-db ronanstokes-db linked an issue Dec 6, 2022 that may be closed by this pull request
@ronanstokes-db ronanstokes-db added this to the v0.3.1 milestone Dec 6, 2022
Copy link
Collaborator

@GeekSheikh GeekSheikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx merged commit aea3f84 into master Dec 7, 2022
@nfx nfx deleted the feature_build_fixes_v2 branch December 7, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Build process improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build fails due to changes to build runner 'ubuntu-latest'

4 participants