Skip to content

Add experimental docker build with latest TF version #4107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shreyas-goenka wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add experimental docker build with latest TF version #4107

shreyas-goenka wants to merge 2 commits into from
+122 −0

Conversation

@shreyas-goenka
Copy link
Contributor

@shreyas-goenka shreyas-goenka commented Dec 8, 2025 •
edited
Loading

Changes

This PR adds an experimental build of the docker image with the latest TF CLI as of 8th December. It is not included as part of our regular release train and is only released at the request of one customer.

Why

To unblock a customer from using DABs.

Tests

The image artifacts have already been uploaded to ghcr.io:

  1. https://github.com/databricks/cli/pkgs/container/cli/602669086?tag=0.279.0-arm64-tf-0.14.0-experimental
  2. https://github.com/databricks/cli/pkgs/container/cli/602668392?tag=0.279.0-amd64-tf-0.14.0-experimental

I've also manually verified that the image runs properly and it chooses the latest TF version:

➜  docker-latest-tf git:(experimental-docker-tf-updated) ✗ docker run --rm -v ~/.databrickscfg:/root/.databrickscfg:ro -v ~/test-bundle:/bundle -w /bundle ghcr.io/databricks/cli:0.279.0-arm64-tf-0.14.0-experimental  bundle deploy --profile DEFAULT --debug
...
00:31:19 Debug: Using Terraform from DATABRICKS_TF_EXEC_PATH at /app/bin/terraform pid=1 mutator=terraform.Plan
...
>   "serial": 1,
>   "terraform_version": "1.14.0",
>   "version": 4
> }
...

@shreyas-goenka shreyas-goenka marked this pull request as ready for review December 8, 2025 00:41
@eng-dev-ecosystem-bot
Copy link
Collaborator

eng-dev-ecosystem-bot commented Dec 8, 2025 •
edited
Loading

Commit: 4906ec8

Run: 20013030051

Env 🔄​flaky 💚​RECOVERED 🙈​SKIP ✅​pass 🙈​skip Time
💚​ aws linux 7 2 374 637 19:30
💚​ aws windows 7 2 376 635 18:10
🔄​ aws-ucws linux 3 4 2 517 522 23:35
💚​ aws-ucws windows 7 2 519 520 23:07
💚​ azure linux 1 4 375 635 17:14
💚​ azure windows 1 4 377 633 19:31
💚​ azure-ucws linux 1 4 514 520 24:14
💚​ azure-ucws windows 1 4 516 518 21:29
💚​ gcp linux 1 4 368 639 18:15
💚​ gcp windows 1 4 370 637 15:47
9 interesting tests: 4 RECOVERED, 3 flaky, 2 SKIP
Test Name aws linux aws windows aws-ucws linux aws-ucws windows azure linux azure windows azure-ucws linux azure-ucws windows gcp linux gcp windows
🔄​ TestAccept 💚​R 💚​R 🔄​f 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
🙈​ TestAccept/bundle/resources/permissions 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🔄​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions 💚​R 💚​R 🔄​f 💚​R 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🔄​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=direct 💚​R 💚​R 🔄​f 💚​R
💚​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=terraform 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions 💚​R 💚​R 💚​R 💚​R 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
💚​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=direct 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=terraform 💚​R 💚​R 💚​R 💚​R
🙈​ TestAccept/bundle/run/app-with-job 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
Top 45 slowest tests (at least 2 minutes):
duration env testname
11:09 aws-ucws linux TestAccept/bundle/resources/synced_database_tables/basic
6:45 aws-ucws windows TestAccept/bundle/resources/synced_database_tables/basic
5:53 aws linux TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:45 aws-ucws windows TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:44 aws windows TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:40 aws-ucws windows TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:38 aws windows TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:36 aws windows TestAccept/ssh/connection
5:32 gcp linux TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:28 aws linux TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:25 gcp windows TestSecretsPutSecretStringValue
5:16 gcp windows TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:14 azure linux TestAccept/ssh/connection
5:11 aws windows TestSecretsPutSecretStringValue
5:09 aws-ucws linux TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:09 aws-ucws windows TestAccept/ssh/connection
5:08 aws-ucws linux TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:07 gcp linux TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:06 azure windows TestSecretsPutSecretStringValue
5:06 gcp windows TestAccept/ssh/connection
5:05 gcp windows TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
4:51 azure-ucws windows TestAccept/ssh/connection
4:49 aws linux TestAccept/ssh/connection
4:30 azure windows TestAccept/ssh/connection
4:13 azure linux TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
4:13 gcp linux TestAccept/ssh/connection
4:10 aws-ucws linux TestAccept/ssh/connection
4:05 azure-ucws linux TestAccept/ssh/connection
4:05 azure-ucws linux TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
4:05 azure linux TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
4:01 azure-ucws windows TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
3:58 azure windows TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
3:56 azure windows TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
3:51 azure-ucws windows TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
3:46 azure-ucws linux TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
3:05 azure linux TestSecretsPutSecretStringValue
3:00 azure-ucws linux TestAccept/bundle/resources/synced_database_tables/basic
2:54 azure-ucws windows TestAccept/bundle/resources/synced_database_tables/basic
2:42 aws linux TestSecretsPutSecretStringValue
2:21 azure-ucws linux TestAccept
2:19 azure windows TestAccept
2:19 gcp linux TestAccept
2:15 aws linux TestAccept
2:14 azure linux TestAccept
2:12 gcp linux TestSecretsPutSecretStringValue

pietern
pietern reviewed Dec 8, 2025
View reviewed changes
Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR summary says 0.14.0 while the version is 1.14.0. Mistake?

Do you want to merge this or keep on a branch because of the one-off nature?

@shreyas-goenka
Copy link
Contributor Author

shreyas-goenka commented Dec 8, 2025

@pietern thanks, yeah, I got the tag wrong. I would prefer to merge this to make this code canonical; we can always remove it later.

The customer seems happy with the image so we don't have to fix the tag retroactively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewnester andrewnester Awaiting requested review from andrewnester andrewnester is a code owner

@anton-107 anton-107 Awaiting requested review from anton-107 anton-107 is a code owner

@denik denik Awaiting requested review from denik denik is a code owner

@pietern pietern Awaiting requested review from pietern pietern is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shreyas-goenka @eng-dev-ecosystem-bot @pietern