Fix test-result job to run even when dependencies are skipped #4096
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test-result job would be skipped if any of its dependencies were skipped, which incorrectly blocked the merge queue. Now it uses `if: always()` to ensure it runs regardless of dependency status, and checks `contains(needs.*.result, 'failure')` to fail only if any dependency actually failed. References: - https://github.com/orgs/community/discussions/25970 - https://github.com/orgs/community/discussions/25789
pietern
requested review from
andrewnester,
anton-107,
denik and
shreyas-goenka
as code owners
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: be17fab
18 interesting tests: 9 flaky, 7 KNOWN, 2 SKIP
Top 21 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The test-result job would be skipped if any of its dependencies were skipped, which incorrectly blocked the merge queue. Now it uses
if: always()to ensure it runs regardless of dependency status, and checkscontains(needs.*.result, 'failure')to fail only if any dependency actually failed.References:
Tests
On this Pr, the test-result job succeeds even though most of the builds were skipped.
The same job was skipped on the PR that added it.