Fix SSH auth failures by enforcing IdentitiesOnly=yes #4095
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a specific ssh key is provided via `-i` or IdentityFile option,the SSH client may still attempt to iterate through all keys loaded in the ssh-agent first. If too many keys are loaded, this causes the server to reject the connection with "Too many authentication failures" before the correct key is attempted.
hamza-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I faced this issue myself when trying the expermental ssh tunnel. since I have couple of keys loaded into my ssh-agent
When a specific ssh key is provided via
-ior IdentityFile option,the SSH client still attempt to auth using all keys loaded in the ssh-agent first. If too many keys are loaded, this causes the server to reject the connection with "Too many authentication failures" before the correct key is attempted.Why
Tests
manually tested the change