MCP: Configure auth on install #4035
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjakobs
requested review from
a team,
lennartkats-db and
pietern
as code owners
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: da6863f
40 failing tests:
Top 50 slowest tests (at least 2 minutes):
|
lennartkats-db
requested changes
Dec 1, 2025
Comment on lines
+36
to
+37
| cmd.Flags().StringP("profile", "p", "", "~/.databrickscfg profile") | ||
| cmd.RegisterFlagCompletionFunc("profile", profile.ProfileCompletion) |
Contributor
There was a problem hiding this comment.
I wouldn't add a flag for this; no one will use it, and we may not want to keep this way of doing authentication in future versions.
| databricksPath, "experimental", "apps-mcp") | ||
| "--env", "DATABRICKS_CONFIG_PROFILE=" + profile.Name, | ||
| "--env", "DATABRICKS_HOST=" + profile.Host, | ||
| "--env", "DATABRICKS_WAREHOUSE_ID=" + warehouseID, |
Contributor
There was a problem hiding this comment.
If you hardcode the warehouse id like this then there should be some way to recover from a bad warehouse id at runtime. Otherwise there will be a new failure path.
(I do like the idea that it's now easier to configure for users btw!)
| } | ||
|
|
||
| // selectProfile checks if a profile is available and prompts the user to select one if needed. | ||
| func selectProfile(cmd *cobra.Command) (*profile.Profile, error) { |
Contributor
There was a problem hiding this comment.
I would still want to provide a built-in path for customers who don't have profiles yet. We should think of that as the common case. The ideal version might be a menu that goes like
[Authenticate to a new workspace...]
workspace 1
workspace 2
...
Alternatively, we could just always rely on OAuth authentication for this V1. And then store the result to a new profile that we give a name like databricks_mcp.
Contributor
There was a problem hiding this comment.
Btw on that note, did you figure out why profiles with tokens weren't supported? A workaround for that problem could be to go for that alternative where we always rely on OAuth?
lennartkats-db
requested changes
Dec 1, 2025
Comment on lines
+37
to
+38
| "--env", "DATABRICKS_CONFIG_PROFILE=" + profile.Name, | ||
| "--env", "DATABRICKS_HOST=" + profile.Host, |
Contributor
There was a problem hiding this comment.
Why hardcode both host and profile?
| "databricks-mcp", | ||
| "--", | ||
| databricksPath, "experimental", "apps-mcp") | ||
| "--env", "DATABRICKS_CONFIG_PROFILE=" + profile.Name, |
Contributor
There was a problem hiding this comment.
As discussed, if we hardcode the host, then there should be something in the server to detect a misconfiguration/authentication failure to help users recover from that state.
fjakobs
force-pushed
the
mcp/auth-on-install
branch
from
6d46f17 to
da6863f
Compare
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
apps-mcp installScreen.Recording.2025-12-01.at.10.27.27.mov
Why
Tests