Fix cell font name and error message (#361) #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error text was referring only to the default font path, obscuring the actual error, which was that unifont.ttf is actually named unifont-10.0.07. This change appears to have always been broken, and may not be desirable on macOS anyway because it changes the cell data font to a less clear monospace font.
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error text was referring only to the default font path, obscuring
the actual error, which was that unifont.ttf is actually named
unifont-10.0.07. This change appears to have always been broken, and may
not be desirable on macOS anyway because it changes the cell data font
to a less clear monospace font.