Skip to content

BUG: fix sign(0+0j) to be zero, not nan #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BUG: fix sign(0+0j) to be zero, not nan #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion array_api_strict/_elementwise_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,5 +352,7 @@ def sign(x: Array, /) -> Array:
raise TypeError("Only numeric dtypes are allowed in sign")
# Special treatment to work around non-compliant NumPy 1.x behaviour
if x.dtype in _complex_floating_dtypes:
return x/abs(x)
_x = x._array
_result = _x / np.abs(np.where(_x != 0, _x, np.asarray(1.0, dtype=_x.dtype)))
return Array._new(_result, device=x.device)
return Array._new(np.sign(x._array), device=x.device)
Loading