Skip to content

Pin static-checking versions and add pre-commit Action #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hristog wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Pin static-checking versions and add pre-commit Action #813

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
52ea8bb
Pin black==20.8b1 and flake8==3.8.3
hristog Mar 28, 2021
5b4d391
Re-format with black==20.8b1
hristog Mar 28, 2021
03ab956
Re-order imports via isort==4.3.21
hristog Mar 28, 2021
0b99bb0
Re-format docs/source/conf.py with black==20.8b1
hristog Mar 28, 2021
c49ea51
Re-order imports using isort==5.8.0 (profile=black)
hristog Mar 28, 2021
8a6f5a6
Enable black and isort to play nicely together
hristog Mar 28, 2021
b0982b1
Fix typo in ci/environment-3.7.yaml
hristog Mar 28, 2021
e74d79f
Update isort config
hristog Mar 28, 2021
e8752c9
Update contribution docs
hristog Mar 28, 2021
fde57e9
Update `isort` config and command-line-arg references
hristog Mar 29, 2021
7f9225d
Merge remote-tracking branch 'dask/main' into pin-code-check-versions
hristog Mar 30, 2021
2246c0d
Add pre-commit GitHub Action
hristog Mar 30, 2021
2f7ff50
Include `mypy` checks in `.pre-commit-config.yaml`
hristog Mar 30, 2021
6740b9e
Pin mypy==0.812
hristog Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/code_checks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ RET=$(($RET + $?)) ; echo $MSG "DONE"

MSG='Checking isort... ' ; echo $MSG
isort --version-number
isort --profile=black --check-only .
isort --check-only .
RET=$(($RET + $?)) ; echo $MSG "DONE"

MSG='Checking mypy... ' ; echo $MSG
Expand Down
2 changes: 1 addition & 1 deletion ci/windows.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
black --check .

echo "[isort]"
isort --profile=black --check-only .
isort --check-only .

echo "[codecov]"
codecov
Expand Down
2 changes: 1 addition & 1 deletion docs/source/contributing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ installed.

black .
flake8
isort --profile=black dask_ml tests
isort .

You may wish to setup a
`pre-commit hook <https://black.readthedocs.io/en/stable/version_control_integration.html>`_
Expand Down
2 changes: 0 additions & 2 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ force_grid_wrap=0
combine_as_imports=True
line_length=88
profile=black
skip=
Copy link
Contributor Author

@hristog hristog Mar 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new profile=black option, skipping docs/source/conf.py is no longer necessary.

docs/source/conf.py

[coverage:run]
source=dask_ml
Expand Down