Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bricks/create_dart_frog/hooks/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1 +1 @@
include: package:very_good_analysis/analysis_options.6.0.0.yaml
include: package:very_good_analysis/analysis_options.yaml
4 changes: 2 additions & 2 deletions bricks/create_dart_frog/hooks/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ environment:
sdk: ">=3.0.0 <4.0.0"

dependencies:
mason: ^0.1.0-dev.39
mason: ^0.1.0
path: ^1.8.1

dev_dependencies:
mocktail: ^1.0.0
test: ^1.25.0
very_good_analysis: ^6.0.0
very_good_analysis: ^9.0.0
6 changes: 5 additions & 1 deletion bricks/dart_frog_dev_server/hooks/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
include: package:very_good_analysis/analysis_options.7.0.0.yaml
include: package:very_good_analysis/analysis_options.yaml
linter:
rules:
# Experimental and there are lots of false positives
specify_nonobvious_property_types: false
4 changes: 2 additions & 2 deletions bricks/dart_frog_dev_server/hooks/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ environment:

dependencies:
dart_frog_gen: ^2.0.0
mason: ^0.1.0-dev.39
mason: ^0.1.0
pubspec_parse: ^1.2.0

dev_dependencies:
mocktail: ^1.0.0
path: ^1.8.2
test: ^1.25.0
very_good_analysis: ^7.0.0
very_good_analysis: ^9.0.0
4 changes: 3 additions & 1 deletion bricks/dart_frog_new/hooks/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
include: package:very_good_analysis/analysis_options.7.0.0.yaml
include: package:very_good_analysis/analysis_options.yaml

linter:
rules:
public_member_api_docs: false
# Experimental and there are lots of false positives
specify_nonobvious_property_types: false
4 changes: 2 additions & 2 deletions bricks/dart_frog_new/hooks/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ environment:

dependencies:
dart_frog_gen: ^2.0.0
mason: ^0.1.0-dev.49
mason: ^0.1.0
path: ^1.8.0

dev_dependencies:
mocktail: ^1.0.0
test: ^1.19.2
very_good_analysis: ^7.0.0
very_good_analysis: ^9.0.0
6 changes: 4 additions & 2 deletions bricks/dart_frog_prod_server/hooks/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
include: package:very_good_analysis/analysis_options.6.0.0.yaml
include: package:very_good_analysis/analysis_options.yaml
linter:
rules:
public_member_api_docs: false
public_member_api_docs: false
# Experimental and there are lots of false positives
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we create a dart frog lint package so we can reuse among packages?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just talked with Felix about that as well and we both concur

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup definitely! related to #548

specify_nonobvious_property_types: false
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Future<void> createBundle({
'${tempDirectory.path}${path.separator}',
);
bundlingProgress.complete();
} catch (error) {
} on Exception catch (error) {
bundlingProgress.fail();
context.logger.err('$error');
return exit(1);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
/// A simple parser for pubspec.lock files.
///
/// This is used by the bundling process to check for those dependencies that
/// are external path dependencies. Hence, it is not a complete parser, it only
/// parses the information that is needed for the bundling process.
library pubspec_lock;

import 'dart:collection';

import 'package:equatable/equatable.dart';
Expand Down Expand Up @@ -35,6 +28,8 @@ class PubspecLock {
late final YamlMap yaml;
try {
yaml = loadYaml(content) as YamlMap;
// ignoring for backward compatibility
// ignore: avoid_catches_without_on_clauses
} catch (_) {
throw const PubspecLockParseException();
}
Expand All @@ -53,6 +48,8 @@ class PubspecLock {
data: entry.value as YamlMap,
);
parsedPackages.add(package);
// ignoring for backward compatibility
// ignore: avoid_catches_without_on_clauses
} catch (_) {
// Ignore those packages that for some reason cannot be parsed.
}
Expand Down
2 changes: 1 addition & 1 deletion bricks/dart_frog_prod_server/hooks/pre_gen.dart
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Future<void> preGen(
final RouteConfiguration configuration;
try {
configuration = buildConfiguration(projectDirectory);
} catch (error) {
} on Exception catch (error) {
context.logger.err('$error');
return exit(1);
}
Expand Down
4 changes: 2 additions & 2 deletions bricks/dart_frog_prod_server/hooks/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ dependencies:
dart_frog_gen: ^2.0.0
equatable: ^2.0.5
io: ^1.0.3
mason: ^0.1.0-dev.39
mason: ^0.1.0
path: ^1.8.1
yaml: ^3.1.2

dev_dependencies:
mocktail: ^1.0.0
test: ^1.25.0
very_good_analysis: ^6.0.0
very_good_analysis: ^9.0.0
3 changes: 0 additions & 3 deletions bricks/dart_frog_prod_server/hooks/test/pubspec_locks.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/// Collection of `pubspec.lock` files used as fixtures during testing.
library pubspec_locks;

/// An artificially crafted `pubspec.lock` file with:
///
/// * A transitive dependency.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// ignoring for testing purposes
// ignore_for_file: prefer_const_constructors

import 'package:dart_frog_prod_server_hooks/src/pubspec_lock/pubspec_lock.dart';
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
include: package:very_good_analysis/analysis_options.7.0.0.yaml
include: package:very_good_analysis/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ dependencies:
dev_dependencies:
mocktail: ^1.0.0
test: ^1.25.0
very_good_analysis: ^7.0.0
very_good_analysis: ^9.0.0
Original file line number Diff line number Diff line change
@@ -1 +1 @@
include: package:very_good_analysis/analysis_options.7.0.0.yaml
include: package:very_good_analysis/analysis_options.yaml
2 changes: 1 addition & 1 deletion examples/todos/packages/todos_data_source/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ dev_dependencies:
json_serializable: ^6.3.1
mocktail: ^1.0.0
test: ^1.25.0
very_good_analysis: ^7.0.0
very_good_analysis: ^9.0.0
2 changes: 1 addition & 1 deletion packages/dart_frog_cli/e2e/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1 +1 @@
include: package:very_good_analysis/analysis_options.7.0.0.yaml
include: package:very_good_analysis/analysis_options.yaml
2 changes: 1 addition & 1 deletion packages/dart_frog_cli/e2e/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ dev_dependencies:
meta: ^1.7.0
path: ^1.8.2
test: ^1.19.2
very_good_analysis: ^7.0.0
very_good_analysis: ^9.0.0
Loading