Skip to content

Proposed Changes to add a Start Trigger and Reset Trigger #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Proposed Changes to add a Start Trigger and Reset Trigger #14

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3adbc4b
added reset and start
GavinThomas1192 Feb 4, 2018
bd88a79
fixed callstack
GavinThomas1192 Feb 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/AudioRecorder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export default class AudioRecorder extends React.Component<AudioRecorderProps, A
};

static defaultProps = {
reset: false,
startRecording: false,
loop: false,
downloadable: true,
Expand Down Expand Up @@ -80,7 +81,7 @@ export default class AudioRecorder extends React.Component<AudioRecorderProps, A
}

componentDidUpdate() {
{ this.props.startRecording ? this.startRecording() : undefined }
{ this.props.startRecording && !this.state.isRecording ? this.startRecording() : undefined }
{ this.props.reset ? this.onRemoveClick() : undefined }
}

Expand Down Expand Up @@ -171,14 +172,14 @@ export default class AudioRecorder extends React.Component<AudioRecorderProps, A
[
'AudioRecorder-button',
this.state.audioData ? 'hasAudio' : '',
this.state.isPlaying ? 'isPlaying' : '',
// this.state.isPlaying ? 'isPlaying' : '',
Copy link
Collaborator

@bzitzow bzitzow Jan 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove commented out code

this.state.isRecording ? 'isRecording' : '',
].join(' ')
}
onClick={this.onButtonClick}
>
{this.state.audioData && !this.state.isPlaying && this.props.playLabel}
{this.state.audioData && this.state.isPlaying && this.props.playingLabel}
{/* {this.state.audioData && this.state.isPlaying && this.props.playingLabel} */}
{!this.state.audioData && !this.state.isRecording && this.props.recordLabel}
{!this.state.audioData && this.state.isRecording && this.props.recordingLabel}
</button>
Expand Down