-
Notifications
You must be signed in to change notification settings - Fork 65
[*] migrate maintenance task logic to PL/pgSQL #1025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0xgouda
wants to merge
10
commits into
cybertec-postgresql:master
Choose a base branch
from
0xgouda:make-maintenance-in-plpgsql
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[*] migrate maintenance task logic to PL/pgSQL #1025
0xgouda
wants to merge
10
commits into
cybertec-postgresql:master
from
0xgouda:make-maintenance-in-plpgsql
+123
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c6510c to
c245c16
Compare
Pull Request Test Coverage Report for Build 19699862818Details
💛 - Coveralls |
pashagolub
reviewed
Nov 24, 2025
- move individual metric update logic to `admin.update_listing_table()`. - move dropped tables removal logic to `admin.remove_dropped_tables_listing()`. - use these new functions in the maintenance routine.
- the `MaintainUniqueSources` test calls `pgw.MaintainUniqueSources()` 3 times which sleeps a minute each time.
c245c16 to
ef84dfc
Compare
Collaborator
|
I want go part look like this: func (pgw *PostgresWriter) MaintainUniqueSources() {
sql := "SELECT admin.maintain_tables() WHERE pg_try_advisory_lock(1571543679778230000)"
logger := log.GetLogger(pgw.ctx)
logger.Info("Starting maintainence...")
if _, err := pgw.sinkDb.Exec(pgw.ctx, sql); err != nil {
logger.Error("Maintaining measurement tables failed:", err)
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
refactoring
Something done as it should've been done from the start
sinks
Where and how to store monitored data
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
admin.try_get_maintenance_lock().admin.update_listing_table(metric_table_name text).admin.remove_dropped_tables_listing(existing_metrics text[]).