feat(Root): cursor strategy support #873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3d6b72a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 NPM canary releaseDeployed canary version 0.0.0-canary-ad2c384. |
Contributor
🧪 Storybook is successfully deployed!
|
Contributor
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| border: '2px solid #007acc', | ||
| borderRadius: '4px', | ||
| cursor: 'pointer', | ||
| cursor: '$pointer', |
There was a problem hiding this comment.
Bug: Inline styles: replace $pointer with CSS var(--pointer)
The cursor property in React inline styles uses the $pointer token, which is specific to the tasty styling system. For standard inline styles, CSS custom properties need to be referenced using var(--pointer).
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds Root
cursorStrategy('web' | 'native') and replaces hard-coded pointer cursors with$pointer/CSS var usage across UI components.cursorStrategy?: 'web' | 'native'prop; sets--pointerCSS var (pointerfor web,defaultfor native).cursor: pointerwith$pointerorvar(--pointer)inAction,Button,ItemAction,Item,Checkbox,FileInput(including hiddenInput),ListBoxcheckbox wrapper,Sliderthumb,Switch(andThumb),CopyPasteBlock,CalendarCell,FileTabstab,Base64Upload.Buttonnow usesdefaultby default,:is(a)->pointer,:is(button)->$pointer,disabled->not-allowed;Itemupdates for:is(a)/:is(button)and menu/listbox roles.HiddenInputand various wrappers align to$pointer.$pointer.Written by Cursor Bugbot for commit 3d6b72a. This will update automatically on new commits. Configure here.