Optimizations for controller memory usage #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch moves the variables and functions common across controllers into its own `utils` package. The related tests have been moved as well. Signed-off-by: Niraj Yadav <niryadav@redhat.com>
mergify
bot
requested review from
Madhu-1,
Nikhil-Ladha,
Rakshith-R,
iPraveenParihar,
nixpanic and
yati1998
black-dragon74
force-pushed
the
fix-exc-mem
branch
from
2a42161 to
76eac37
Compare
This patch adds a new controller for PVC objects which differs from existing controller in the following main ways: - Only supports annotations on StorageClasses - Sets us a silent watch on PV objects to optimize lookups. - Uses deterministic naming for child resources to avoid manual house keeping. Signed-off-by: Niraj Yadav <niryadav@redhat.com>
when SchedulePrecedence is set to `StorageClass` Signed-off-by: Niraj Yadav <niryadav@redhat.com>
This patch adds a silent watch on VolumeAttachment objects to avoid unexpected memory consumption due to `List` calls. It is okay to setup a watch in two places as the Informer is shared and managed by the Manager. Signed-off-by: Niraj Yadav <niryadav@redhat.com>
black-dragon74
force-pushed
the
fix-exc-mem
branch
from
76eac37 to
ae4b739
Compare
Member
|
@black-dragon74 can you please share the result of the memory optimization after this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to optimize memory consumption and allocation for csi-addons controller. This goal is achieved mainly by:
schedule-precedenceis set tostorageclass.controller/utilspackage.Closes: #815
** We need to consider the (non-deterministic) resources that will be already present on the cluster. That part is still WIP (hence the DNM) and I am open to suggestions.