Skip to content

Conversation

@amotl
Copy link
Member

@amotl amotl commented Jul 28, 2023

@amotl amotl mentioned this pull request Aug 25, 2023
@amotl amotl force-pushed the amo/basic-ng branch 2 times, most recently from 34bba3b to 6bc6edc Compare July 1, 2024 15:32
Base automatically changed from amo/basic-ng to main August 7, 2024 15:30
@amotl amotl force-pushed the amo/basig-ng-navigation branch 2 times, most recently from f8e2bc6 to 56c112b Compare November 23, 2024 11:26
@amotl amotl force-pushed the amo/basig-ng-navigation branch from 56c112b to b465178 Compare December 9, 2025 23:57
@bmunkholm
Copy link
Contributor

@amotl Do you recall what was left to make this work?

@amotl
Copy link
Member Author

amotl commented Dec 10, 2025

Hi Brian,

currently, it's just an alpha / proof-of-concept, but ready enough that I was satisfied for the time being. Possibly not much is missing, but I lost track, and I guess you know about the pareto thing and its 80/20 rule mostly related to getting the nitty gritty details right.

First, we need to wrap up tech-writing/sphinx-design-elements#11, then this one. Do you think there would be a benefit by having better composition of toctrees, like @robtaylor stated at tech-writing/sphinx-design-elements#11 (comment)?

I was looking for intersphinx support in toctree, but also better composition of toctrees would be a great help!

I mean, of course it's a rhetorical question, because I think the tracking ticket makes it clear this feature would be something the community could benefit from, and without the mix of our and other's needs, I wouldn't have bothered to explore this topic.

So, let's phrase my question differently: Do you think it's finally time to wrap up this proof-of-concept into shippable software, possibly just in time for Christmas?

With kind regards,
Andreas.

"sphinx-basic-ng==1.0.0b2",
"sphinx-copybutton>=0.3.1,<1",
"sphinx-design-elements==0.4.0",
"sphinx-design-elements @ git+https://github.com/tech-writing/sphinx-design-elements@linktree",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to assemble this yesterday to see what's missing....

Copy link
Member Author

@amotl amotl Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and encountered an "unexpected" exception on CI:

ImportError: cannot import name 'TocTree' from 'sphinx.environment'

-- https://github.com/crate/crate-docs-theme/actions/runs/20082409491/job/57612387226?pr=405#step:7:492

Copy link
Member Author

@amotl amotl Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this doesn't mean much, because it's all just a draft, originally conceived more than two years ago. However, it highlights that software parts currently do NOT fit together well, so the package needs some more love. A little import error per se is nothing to worry about, I am sure there might be the one or the other different obstacle along the way to general availability.

Copy link
Contributor

@bmunkholm bmunkholm Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a fix for the build issue. But yeah, looking at the code and the amount of remaining todos, it seems there still is quite a bit of work left? While this is likely a better way, it's probably a bit too involved for me at this moment.

@amotl amotl force-pushed the amo/basig-ng-navigation branch 2 times, most recently from cd47b09 to 1537713 Compare December 14, 2025 02:13
@amotl amotl force-pushed the amo/basig-ng-navigation branch from 1537713 to 05e2576 Compare December 14, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants