-
Notifications
You must be signed in to change notification settings - Fork 5
Use Furo's navigation component through sphinx-design-elements' linktree
#405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
34bba3b to
6bc6edc
Compare
f8e2bc6 to
56c112b
Compare
56c112b to
b465178
Compare
|
@amotl Do you recall what was left to make this work? |
|
Hi Brian, currently, it's just an alpha / proof-of-concept, but ready enough that I was satisfied for the time being. Possibly not much is missing, but I lost track, and I guess you know about the pareto thing and its 80/20 rule mostly related to getting the nitty gritty details right. First, we need to wrap up tech-writing/sphinx-design-elements#11, then this one. Do you think there would be a benefit by having better composition of toctrees, like @robtaylor stated at tech-writing/sphinx-design-elements#11 (comment)?
I mean, of course it's a rhetorical question, because I think the tracking ticket makes it clear this feature would be something the community could benefit from, and without the mix of our and other's needs, I wouldn't have bothered to explore this topic. So, let's phrase my question differently: Do you think it's finally time to wrap up this proof-of-concept into shippable software, possibly just in time for Christmas? With kind regards, |
| "sphinx-basic-ng==1.0.0b2", | ||
| "sphinx-copybutton>=0.3.1,<1", | ||
| "sphinx-design-elements==0.4.0", | ||
| "sphinx-design-elements @ git+https://github.com/tech-writing/sphinx-design-elements@linktree", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to assemble this yesterday to see what's missing....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... and encountered an "unexpected" exception on CI:
ImportError: cannot import name 'TocTree' from 'sphinx.environment'-- https://github.com/crate/crate-docs-theme/actions/runs/20082409491/job/57612387226?pr=405#step:7:492
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this doesn't mean much, because it's all just a draft, originally conceived more than two years ago. However, it highlights that software parts currently do NOT fit together well, so the package needs some more love. A little import error per se is nothing to worry about, I am sure there might be the one or the other different obstacle along the way to general availability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested a fix for the build issue. But yeah, looking at the code and the amount of remaining todos, it seems there still is quite a bit of work left? While this is likely a better way, it's probably a bit too involved for me at this moment.
cd47b09 to
1537713
Compare
1537713 to
05e2576
Compare
About
What the title says. Still WIP.
Preview
References
linktreetech-writing/sphinx-design-elements#11