Exporting Functions for Windows Library

We did not export any of your functions. This is important on Windows,
otherwise no *.lib gets build and you can't use the library. This was
fixed by using GenerateExportHeader module from cmake. CMake defines a
macro that you can use to export functions.

Signed-off-by: Christian Rapp <0x2a@posteo.org>

Author: crapp

include/qAccordion/clickableframe.h

@@ -25,6 +25,7 @@
 #include <QGraphicsView>
 
 #include "config.h"
+#include "qaccordion_export.h"
 
 // TODO: No need to use a namespace for our constants as we are using them only
 // in this class
@@ -40,7 +41,7 @@ const char *const CARRET_ICON_OPENED = ":/qAccordionIcons/caret-bottom.png"; /**
  * This class represents a clickable QFrame. It is used by a ContentPane. The class
  * is used internally.
  */
-class ClickableFrame : public QFrame
+class QACCORDION_EXPORT ClickableFrame : public QFrame
 {
 
     Q_OBJECT

include/qAccordion/contentpane.h

@@ -29,9 +29,11 @@
 #include <memory>
 
 #include "config.h"
+#include "qaccordion_export.h"
 #include "clickableframe.h"
 #include "qaccordion.h"
 
+// TODO: Do i really need to export the ClickableFrame class?
 /**
  * @brief Content Pane class
  *
@@ -61,7 +63,7 @@
  * @details
  * The animation speed is influenceable setAnimationDuration().
  */
-class ContentPane : public QWidget
+class QACCORDION_EXPORT ContentPane : public QWidget
 {
     Q_OBJECT
 public:

include/qAccordion/qaccordion.h

@@ -33,6 +33,7 @@
 #include <iterator>
 
 #include "config.h"
+#include "qaccordion_export.h"
 #include "contentpane.h"
 
 class ContentPane;
@@ -64,7 +65,7 @@ class ContentPane;
  * Currently Headers have to be unique
  *
  */
-class QAccordion : public QWidget
+class QACCORDION_EXPORT QAccordion : public QWidget
 {
     Q_OBJECT
 public:

src/CMakeLists.txt

@@ -10,26 +10,26 @@ set(CMAKE_CXX_FLAGS_RELEASE        "-O4 -DNDEBUG")
 set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O2 -g")
 
 # Compiler-specific C++11 activation.
-if ("${CMAKE_CXX_COMPILER_ID}" MATCHES "GNU")
+if (${CMAKE_CXX_COMPILER_ID} MATCHES "GNU")
     execute_process(
         COMMAND ${CMAKE_CXX_COMPILER} -dumpversion OUTPUT_VARIABLE GCC_VERSION)
     if (NOT (GCC_VERSION VERSION_GREATER 4.7 OR GCC_VERSION VERSION_EQUAL 4.7))
         message(FATAL_ERROR "${PROJECT_NAME} requires g++ 4.7 or greater.")
     endif ()
-elseif ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
+elseif (${CMAKE_CXX_COMPILER_ID} MATCHES "Clang")
     if (${CMAKE_SYSTEM_NAME} MATCHES "Linux")
         set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -stdlib=libstdc++")
     elseif (${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
         set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -stdlib=libc++")
     endif()
 elseif(WIN32)
     # So far only msvc is supported on Windows.
-    if (NOT CMAKE_CXX_COMPILER_ID MATCHES MSVC)
+    if (NOT CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
     message(
       ERROR
       "qAccordion does not support compiling on Windows with "
       "${CMAKE_CXX_COMPILER_ID}. Please use MSVC.")
-    endif (NOT CMAKE_CXX_COMPILER_ID MATCHES MSVC)
+    endif (NOT CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
 
     # MSVC 1800 supports C++11; earlier versions don't. So, warn if you try to
     # use anything else.
@@ -47,6 +47,9 @@ else ()
     message(FATAL_ERROR "Your C++ compiler does not support C++11.")
 endif ()
 
+# include GenerateExportHeader module
+include(GenerateExportHeader)
+
 # Find includes in corresponding build directories
 set(CMAKE_INCLUDE_CURRENT_DIR ON)
 # Instruct CMake to run moc automatically when needed.
@@ -62,12 +65,8 @@ else ()
     set(base_path ${CMAKE_SOURCE_DIR})
 endif()
 
-message(STATUS "base path: ${base_path}")
-
-
-# include this directories so all moc headers and wrapped ui files are found
 include_directories(
-    ${PROJECT_BINARY_DIR}
+    ${PROJECT_BINARY_DIR} # include this directory so all moc headers and wrapped ui files are found
     ${base_path}/include
 )
 
@@ -88,9 +87,13 @@ set(QACCORDION_ICON_RESOURCE "${base_path}/icons/qaccordionicons.qrc")
 # add resource files so they can be compiled into the binary
 qt5_add_resources(ICON_RESOURCE_ADDED ${QACCORDION_ICON_RESOURCE})
 
+# we are building a shared library
 add_library (qAccordion SHARED ${QACCORDION_HEADER} ${QACCORDION_SOURCE} ${ICON_RESOURCE_ADDED})
 target_link_libraries(qAccordion Qt5::Widgets)
 
+# generate the export header. this will be used to define a macro that exports functions on windows.
+generate_export_header(qAccordion)
+
 if (QACCORDION_BUILD_TESTER)
     # generate ui_*.h files
     qt5_wrap_ui(accordion_tester_FORMS ${TEST_UI})
@@ -104,3 +107,4 @@ install(FILES ${base_path}/include/qAccordion/clickableframe.h DESTINATION inclu
 install(FILES ${base_path}/include/qAccordion/contentpane.h DESTINATION include/qAccordion)
 install(FILES ${base_path}/include/qAccordion/qaccordion.h DESTINATION include/qAccordion)
 install(FILES ${CMAKE_CURRENT_BINARY_DIR}/config.h DESTINATION include/qAccordion)
+install(FILES ${CMAKE_CURRENT_BINARY_DIR}/qaccordion_export.h DESTINATION include/qAccordion)