Fix support for MSVC

This commit brings MSVC support.
CMake now checks for this compiler. You need MSVC Version 12.0 (VS2013)
or later.
I have also added the Macro ATTR_UNUSED. Clang does work with
__attribute__ ((unused)) but MSVC doesn't. The macro ensures we use
this feature only with gcc.

Fixes #1

Signed-off-by: Christian Rapp <0x2a@posteo.org>

Author: crapp

include/qAccordion/clickableframe.h

@@ -24,6 +24,8 @@
 #include <QLabel>
 #include <QGraphicsView>
 
+#include "config.h"
+
 // TODO: No need to use a namespace for our constants as we are using them only
 // in this class
 namespace ClickableFrame_constants

include/qAccordion/config.h.in

@@ -21,6 +21,10 @@
 #define VERSION_MINOR "@qAccordion_VERSION_MINOR@"
 #define VERSION_PATCH "@qAccordion_VERSION_PATCH@"
 
-//#cmakedefine
+#ifdef __GNUC__
+  #define ATTR_UNUSED __attribute__((unused))
+#else
+  #define ATTR_UNUSED
+#endif
 
 #endif // CONFIG_H_IN

include/qAccordion/contentpane.h

@@ -28,6 +28,7 @@
 
 #include <memory>
 
+#include "config.h"
 #include "clickableframe.h"
 #include "qaccordion.h"
 
@@ -301,7 +302,7 @@ private slots:
      * @brief paintEvent Reimplement paintEvent to use stylesheets in derived Widgets
      * @param event
      */
-    void paintEvent(__attribute__((unused)) QPaintEvent *event);
+    void paintEvent(ATTR_UNUSED QPaintEvent *event);
 };
 
 #endif // CONTENTPANE_H

include/qAccordion/qaccordion.h

@@ -377,7 +377,7 @@ private slots:
      * @brief paintEvent Reimplement paintEvent to use stylesheets in derived Widgets
      * @param event
      */
-    void paintEvent(__attribute__((unused)) QPaintEvent *event);
+    void paintEvent(ATTR_UNUSED QPaintEvent *event);
 };
 
 #endif // QACCORDION_H

src/CMakeLists.txt

@@ -1,6 +1,10 @@
 # Initialize CXXFLAGS.
 set(CMAKE_CXX_FLAGS                "${CMAKE_CXX_FLAGS} -Wall -std=c++11")
-set(CMAKE_CXX_FLAGS_DEBUG          "-Wextra -O0 -g -Wno-reorder") # No reorder warnings since this pop up frequently if you are using the Q_OBJECT macro
+set(CMAKE_CXX_FLAGS_DEBUG          "-O0 -g") # No reorder warnings since this pop up frequently if you are using the Q_OBJECT macro
+if (NOT CMAKE_CXX_COMPILER_ID MATCHES MSVC)
+    # these flags really hurt msvc so we add them here
+    set(CMAKE_CXX_FLAGS_DEBUG         "${CMAKE_CXX_FLAGS_DEBUG} -Wextra -Wno-reorder")
+endif(NOT CMAKE_CXX_COMPILER_ID MATCHES MSVC)
 set(CMAKE_CXX_FLAGS_MINSIZEREL     "-Os -DNDEBUG")
 set(CMAKE_CXX_FLAGS_RELEASE        "-O4 -DNDEBUG")
 set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O2 -g")
@@ -18,6 +22,27 @@ elseif ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
     elseif (${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
         set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -stdlib=libc++")
     endif()
+elseif(WIN32)
+    # So far only msvc is supported on Windows.
+    if (NOT CMAKE_CXX_COMPILER_ID MATCHES MSVC)
+    message(
+      ERROR
+      "qAccordion does not support compiling on Windows with "
+      "${CMAKE_CXX_COMPILER_ID}. Please use MSVC.")
+    endif (NOT CMAKE_CXX_COMPILER_ID MATCHES MSVC)
+
+    # MSVC 1800 supports C++11; earlier versions don't. So, warn if you try to
+    # use anything else.
+    if (${MSVC_VERSION} LESS 1800)
+    message(
+      ERROR
+      "qAccordion does not support compiling on MSVC versions earlier than 1800. "
+      "Please use MSVC 1800 (included with Visual Studio 2013 or later).")
+    endif (${MSVC_VERSION} LESS 1800)
+
+    set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} /MTd")
+    set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} /MT")
+
 else ()
     message(FATAL_ERROR "Your C++ compiler does not support C++11.")
 endif ()

src/clickableframe.cpp

@@ -99,14 +99,14 @@ void ClickableFrame::mousePressEvent(QMouseEvent *event)
     }
 }
 
-void ClickableFrame::enterEvent(__attribute__ ((unused)) QEvent *event)
+void ClickableFrame::enterEvent(ATTR_UNUSED QEvent *event)
 {
     if (this->clickable) {
         this->setStyleSheet(this->hoverStylesheet);
     }
 }
 
-void ClickableFrame::leaveEvent(__attribute__ ((unused)) QEvent *event)
+void ClickableFrame::leaveEvent(ATTR_UNUSED QEvent *event)
 {
     if (this->clickable) {
         this->setStyleSheet(this->normalStylesheet);

src/contentpane.cpp

@@ -204,11 +204,11 @@ void ContentPane::initAnimations()
                 QEasingCurve(QEasingCurve::Type::Linear));
 }
 
-void ContentPane::headerClicked(__attribute__((unused)) QPoint pos) {
+void ContentPane::headerClicked(ATTR_UNUSED QPoint pos) {
     emit this->clicked();
 }
 
-void ContentPane::paintEvent(__attribute__((unused)) QPaintEvent *event)
+void ContentPane::paintEvent(ATTR_UNUSED QPaintEvent *event)
 {
     QStyleOption o;
     o.initFrom(this);

src/qaccordion.cpp

@@ -410,7 +410,7 @@ void QAccordion::numberOfPanesChanged(int number)
     }
 }
 
-void QAccordion::paintEvent(__attribute__((unused)) QPaintEvent *event)
+void QAccordion::paintEvent(ATTR_UNUSED QPaintEvent *event)
 {
     QStyleOption o;
     o.initFrom(this);