-
Notifications
You must be signed in to change notification settings - Fork 24
Bump actions/checkout from 4 to 5 #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2bndy5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems dependabot does not look for workflows recursively. Its a shame that we have to do this manually and dependabot is oddly configured for the github_actions ecosystem.
WalkthroughUpdated actions/checkout from v4 to v5 in three example GitHub Actions workflows and aligned the README snippet accordingly. No other workflow logic or code was changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
.github/workflows/examples/only-clang-tidy.yml (1)
14-14: Optional: Consider pinning the action for supply-chain hardeningIf your policy prefers immutable refs, pin to a specific tag (e.g., v5.x.y) or commit SHA instead of the floating major tag.
.github/workflows/examples/only-clang-format.yml (1)
14-14: Optional: Pin to a stable tag or commit SHAUsing an immutable ref (v5.x.y or a commit SHA) can reduce supply-chain risk in examples.
.github/workflows/examples/only-PR-comments.yml (1)
16-16: Optional: Pin the action versionConsider pinning to v5.x.y or a commit SHA for reproducibility.
README.md (1)
53-53: Optional: Encourage readers to pin versions in CI snippetsFor best practices in security/reproducibility, consider showing a pinned tag (v5.x.y) or commit SHA in the snippet.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/examples/only-PR-comments.yml(1 hunks).github/workflows/examples/only-clang-format.yml(1 hunks).github/workflows/examples/only-clang-tidy.yml(1 hunks)README.md(1 hunks)
🔇 Additional comments (8)
.github/workflows/examples/only-clang-tidy.yml (2)
14-14: LGTM: checkout bumped to v5 as intendedThe upgrade is scoped and safe; no other workflow logic changed.
14-14: All actions/checkout references updated to @v5No occurrences of actions/checkout@v4 remain—every workflow and doc now uses actions/checkout@v5:
• README.md:53
• .github/workflows/cpp-linter.yml:16
• .github/workflows/self-test.yml:39
• .github/workflows/release.yml:22
• .github/workflows/examples/only-clang-format.yml:14
• .github/workflows/examples/only-PR-comments.yml:16
• .github/workflows/examples/only-clang-tidy.yml:14No further updates needed.
.github/workflows/examples/only-clang-format.yml (2)
14-14: LGTM: updated to actions/checkout@v5Change is minimal and aligned with the PR objective.
14-14: All workflows reference actions/checkout@v5
I ran a repository-wide search and confirmed every workflow usingactions/checkoutis on@v5; no@v4references remain..github/workflows/examples/only-PR-comments.yml (2)
16-16: LGTM: checkout moved to v5; permissions already constrainedThe job already scopes permissions (pull-requests: write). No other adjustments needed for the bump.
16-16: No remaining actions/checkout@v4 referencesScanned all YAML and Markdown files in the repo and confirmed there are no lingering
actions/checkout@v4usages. Everything is correctly updated to@v5.README.md (2)
53-53: LGTM: documentation snippet now uses actions/checkout@v5Docs match the updated example workflows.
53-53: All documentation references have been updated to v5I’ve searched
README.md, thedocs/folder, and all.mdfiles foractions/checkout@v4and found no remaining occurrences.
Not sure why #304 also does not work as expected to bump
actions/checkoutfrom 4 to 5 automaticllyMaybe we should bump it manually and include README.md
Summary by CodeRabbit