-
Notifications
You must be signed in to change notification settings - Fork 24
chore: update dependency config to monitor multiple locations #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughUpdated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Dependabot configuration to monitor GitHub Actions files across multiple directories instead of just the root directory. The change enables automatic dependency updates for both the main workflows and example workflows.
- Changes Dependabot to use
directoriesinstead ofdirectoryto monitor multiple locations - Adds monitoring for both
.github/workflowsanddocs/examplesdirectories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/dependabot.yml(1 hunks)
🔇 Additional comments (1)
.github/dependabot.yml (1)
9-11: Ignore absolute-path suggestion fordirectoriesDependabot’s
directoriesentries must be repo-relative (no leading slash). The existing paths".github/workflows" "docs/examples"are correct and should not be changed to
"/.github/workflows"or"/docs/examples".Likely an incorrect or invalid review comment.
Co-authored-by: Brendan <2bndy5@gmail.com>
|
We may need to cut a new release to clear the backlog and maintain the release cadence once this PR is merged. (I will manually trigger dependency to test this PR after merge) |
2bndy5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If dependabot does not like this patch we can always revert it and move the example workflows from docs/examples to .github/workflows/examples
|
I expect another bump version PR to be created by this run https://github.com/cpp-linter/cpp-linter-action/actions/runs/16904279566/job/47890296111, but it did not happen. |
|
Its strange. Looking at those logs, I see a lot of garbage that is not useful to us as consumers. However, I did find the following logs:
Not sure why we are not seeing this alleged PR. I'm also not sure what "filtering allowed updates" means. Plan BWe could instead move the workflows from docs/examples to .github/workflows/examples. That should achieve what we wanted here. But the docs source needs to be updated for the changed paths. There might be a complication from mkdocs about using sources outside the docs/ folder... |
Address #302 (comment)
We can use
directoriesto update github-actions files across multiple locationsBut the only issue is that we can not test the action from
docs/examplesfolder.Summary by CodeRabbit