Skip to content

Replace deprecated classifier with licence expression (PEP 639) #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Replace deprecated classifier with licence expression (PEP 639) #110

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c1bbe8
Replace deprecated classifier with licence expression (PEP 639)
shenxianpeng Feb 20, 2025
7ef581b
Update pyproject.toml
shenxianpeng Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ name = "clang_tools"
description = "Install clang-tools (clang-format, clang-tidy, clang-query, clang-apply-replacements) with pip"
readme = "README.rst"
keywords = ["clang", "clang-tools", "clang-extra", "clang-tidy", "clang-format", "clang-query", "clang-apply-replacements"]
license = {text = "MIT License"}
license = "MIT"
license-files = [ "LICENSE" ]
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

⚠️ Potential issue

Critical Issue: Invalid project.license Format Causing Schema Validation Error

The new change sets the license as a bare string (license = "MIT"). However, the pipeline error indicates that the schema expects the project.license field to be unambiguously defined as a table—with either a "text" key or a "file" key—not as a plain string. To resolve this conflict, please update the license declaration to a table format. For example, the diff below would address the issue:

-license = "MIT"
+license = { text = "MIT" }

The accompanying license-files entry (line 11) is acceptable if you intend to signal where the license file is located.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
license = "MIT"
license-files = [ "LICENSE" ]
license = { text = "MIT" }
license-files = [ "LICENSE" ]

authors = [
{ name = "Xianpeng Shen", email = "xianpeng.shen@gmail.com" },
{ name = "Brendan Doherty", email = "2bndy5@gmail.com" },
Expand Down
Loading