Add arm builds #102
Closed
Add arm builds #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shenxianpeng
requested changes
Aug 14, 2025
Collaborator
shenxianpeng
left a comment
shenxianpeng
left a comment
There was a problem hiding this comment.
I don't think it needs to add too much code here
It should be something like
clang-tools-docker/docker-bake.hcl
Line 170 in f67f8ee
Collaborator
| build: | ||
| needs: extract-targets | ||
| runs-on: ubuntu-latest |
Collaborator
There was a problem hiding this comment.
Suggested change
| runs-on: ubuntu-latest |
| strategy: | ||
| matrix: | ||
| target: [ "all", "20", "20-alpine", "19", "19-alpine", "18", "18-alpine", "17", "17-alpine", "16", "16-alpine", "15", "14", "13", "12", "11", "10", "9", "8", "7"] | ||
| target: ${{ fromJson(needs.extract-targets.outputs.targets) }} |
Collaborator
|
Since I’ve added arm64 support and some Alpine images #101, it might be a good idea to start working from the master branch. |
Contributor
Author
|
Ok thanks I'll have a look |
Contributor
Author
|
I'll close this and add another PR for the CI. I think you already implemented the rest on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add arm build to use this on mac with M1 chip.
Also add the alpine version to all targets and automatically get the build list from the buildx cofnig in the ci